Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renew DNS Records: Always Clickable #612

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Renew DNS Records: Always Clickable #612

merged 1 commit into from
Apr 13, 2023

Conversation

Ririio
Copy link
Contributor

@Ririio Ririio commented Apr 13, 2023

A record will not disable past 6 months as seen here

image

When the renew button is clicked, it will display a toast

image

@Ririio Ririio added the category: front end Front end part of our web service label Apr 13, 2023
@Ririio Ririio added this to the Milestone 1.0a milestone Apr 13, 2023
@Ririio Ririio requested review from humphd and Myrfion April 13, 2023 14:36
@Ririio Ririio self-assigned this Apr 13, 2023
@Ririio Ririio merged commit 75b87e1 into DevelopingSpace:main Apr 13, 2023
@Ririio Ririio deleted the issue-558 branch April 13, 2023 16:27
@Genne23v Genne23v linked an issue Apr 13, 2023 that may be closed by this pull request
Remove isRenewable logic for DNS Records and always allow in UI #558
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eakam1007 Eakam1007 Eakam1007 approved these changes

@humphd humphd humphd approved these changes

@Myrfion Myrfion Awaiting requested review from Myrfion

Assignees

@Ririio Ririio

Labels
category: front end Front end part of our web service
Projects
None yet
Milestone
Milestone 1.0a
Development

Successfully merging this pull request may close these issues.

Remove isRenewable logic for DNS Records and always allow in UI
3 participants
@Ririio @humphd @Eakam1007