Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ca parameter in verifySigningChain optional #117

Closed
basbossink opened this issue Apr 5, 2017 · 2 comments
Closed

Make ca parameter in verifySigningChain optional #117

basbossink opened this issue Apr 5, 2017 · 2 comments
Labels
enhancement Hacktoberfest

Comments

@basbossink
Copy link

When using the verifySigningChain function and leaving the ca parameter undefined, the pem module passes an empty temporary file to openssl in the -CAFile parameter, causing it to report an error. Since the -CAFile parameter is optional it would be nice if the ca parameter of the verifySigningChain function can be left undefined as well.

If interested I would be willing to submit a pull request to implement this enhancement.
@Dexus
Copy link
Owner

Dexus commented Apr 5, 2017

A PR is allways welcome.

@basbossink
Copy link
Author

Nice, I'll try to move this forward. I have adjusted the production code, I still have to fix a number of tests to complete the PR.

Dexus pushed a commit that referenced this issue Oct 10, 2017
fix(package): #117 verifySigningChain optional CA certificates
b4eeed4
@Dexus Dexus mentioned this issue Oct 10, 2017
Merged
Dexus pushed a commit that referenced this issue Oct 10, 2017
@Dexus
fix(package): #117 verifySigningChain optional CA certificates
d84c2a0
Dexus pushed a commit that referenced this issue Oct 10, 2017
@Dexus
fix(package): #117 verifySigningChain optional CA certificates
b6aafd4
@Dexus Dexus closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@basbossink @Dexus