Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional genrsa option support #23

Closed
jcottr opened this issue Nov 10, 2014 · 3 comments
Closed

Additional genrsa option support #23

jcottr opened this issue Nov 10, 2014 · 3 comments

Comments

@jcottr
Copy link

jcottr commented Nov 10, 2014

createPrivateKey() only takes one option (keyBitsize), while genrsa offers many additional options; most commonly used are:

  • encryption cipher (e.g. des3, aes256)
  • encryption password

I would fork and patch, but it looks like the current implementation is very permissive about the type of keyBitsize, so I worry that any change I would make might break some existing clients. I could prepare a patch that expects an options object instead of keyBitsize, but I think we'd need to rev the major version. Is that something you're okay with?

@andris9
Copy link
Collaborator

andris9 commented Nov 11, 2014

I don't have any preferences as long as it doesn't break existing clients. You could add an optional argument that includes the new params and if the argument is missing it wouldn't be used – this would keep old clients running but would allow to use the new stuff.

@Dexus
Copy link
Owner

Dexus commented Feb 24, 2015

@jcottr
tomorrow i will look at this and add optional param for encryption and password.

@Dexus
Copy link
Owner

Dexus commented Feb 25, 2015

#48 - can now be closed

@andris9 andris9 closed this as completed Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants