Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added noop callback (Node 7.0 deprecation warning) #91

Merged
merged 1 commit into from
Nov 13, 2016

Conversation

vizo
Copy link
Contributor

@vizo vizo commented Nov 9, 2016

No description provided.

@gajus
Copy link

gajus commented Nov 13, 2016

@andris9 can you please merge this?

although, I'd like this to throw an error if there is an error.

@andris9 andris9 merged commit 5b4aac7 into Dexus:master Nov 13, 2016
@gajus
Copy link

gajus commented Nov 14, 2016

@andris9 Please release this change. Its flooding logs at the moment.

@andris9
Copy link
Collaborator

andris9 commented Nov 14, 2016

@gajus You have to ask @Dexus as he is doing the releases

@gajus
Copy link

gajus commented Nov 14, 2016

@Dexus can you please do the release?

It would be nice to add either more people to NPM or use something like https://github.com/semantic-release/semantic-release to automate the release process.

@Dexus
Copy link
Owner

Dexus commented Nov 14, 2016

Yeah i will do, but currently i'm on a business trip so it will maybe two weeks. Have here no key for my system.

Regards,
Josef

Von meinem iPhone gesendet

Am 14.11.2016 um 14:00 schrieb Gajus Kuizinas notifications@github.com:

@Dexus can you please do the release?

It would be nice to add either more people to NPM or use something like https://github.com/semantic-release/semantic-release to automate the release process.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@gajus
Copy link

gajus commented Nov 14, 2016

Yeah i will do, but currently i'm on a business trip so it will maybe two weeks. Have here no key for my system.

Can you add me as a collaborator to NPM? This can be done via the web UI. My username is "gajus".

@Dexus
Copy link
Owner

Dexus commented Nov 14, 2016

From here i'm also unable to login to NPM. I have only my work laptop and not access to any private keys and passwords.

Regards, Josef

Von meinem iPhone gesendet

Am 14.11.2016 um 19:31 schrieb Gajus Kuizinas notifications@github.com:

Yeah i will do, but currently i'm on a business trip so it will maybe two weeks. Have here no key for my system.

Can you add me as a collaborator to NPM? This can be done via the web UI. My username is "gajus".


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Dexus referenced this pull request Nov 28, 2016
This is a follow up to https://github.com/andris9/pem/pull/91, ensuring that errors from fs.unlink() calls get bubbled up correctly. This also ensures all fs.unlink() calls have a callback, which is important to avoid deprecation warnings on Node 7.
Dexus referenced this pull request Dec 1, 2016
This is a follow up to https://github.com/andris9/pem/pull/91, ensuring that errors from fs.unlink() calls get bubbled up correctly. This also ensures all fs.unlink() calls have a callback, which is important to avoid deprecation warnings on Node 7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants