fix stats reading in case there are multiple with same lostat identifier #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there were multiple stats with same LoStatID the GetStatsMap function would break.
So instead of using x.Single() we now use x.First().
The bug is exposed by adding more StatIdentifiers, specifically in this case stat 0x6B (1501edc#diff-81eadb67a3a99129f099fe8d0230e9f7f1de1b30ea59330ae814d880fbf75f88R133) which occurs multiple times for the attached character save (leaf equipped)
The stat 0x6B is not used atm for anything and was just added for documentation purpose, so this fix should be fine, but needs more investigation.
rose.zip