Adjust position and z-index of region control dropdown #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marySalvi
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Looks good to me.
I checked to make sure this did not affect standard HistomicsUI analysis since this applies to the region-dropdown class and not specific to slicer_cli_web, it appears to work across the board.
I will leave official review/approval to @manthey in case this affects other analysis.
gabrielle6249
changed the title
manthey
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the z-index and position of the second region control's drop down button so it doesn't cover the first region control's drop down menu, an issue raised here