Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Dioxus 0.5 support #23

Merged
merged 29 commits into from
Mar 28, 2024
Merged

feat: Dioxus 0.5 support #23

merged 29 commits into from
Mar 28, 2024

Conversation

marc2332
Copy link
Collaborator

@marc2332 marc2332 commented Jan 23, 2024 •
edited
Loading

Prepare support for Dioxus 0.5

@DogeDark DogeDark added the waiting on next dioxus release Waiting on the next Dioxus release before action. label Jan 23, 2024
marc2332
marc2332 commented Feb 8, 2024
View reviewed changes
Copy link
Collaborator Author

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should derive Copy in the hooks

@marc2332 marc2332 mentioned this pull request Feb 8, 2024
Merged
@marc2332 marc2332 marked this pull request as ready for review February 9, 2024 15:51
@marc2332
Copy link
Collaborator Author

marc2332 commented Feb 9, 2024 •
edited
Loading

Why are the workflows skipped?

marc2332
marc2332 commented Mar 15, 2024
View reviewed changes
std/src/clipboard/use_clipboard.rs Show resolved Hide resolved
std/src/clipboard/use_clipboard.rs Outdated Show resolved Hide resolved
std/src/clipboard/use_clipboard.rs Outdated Show resolved Hide resolved
std/src/clipboard/use_clipboard.rs Show resolved Hide resolved
@marc2332 marc2332 requested a review from DogeDark March 19, 2024 19:33
DogeDark
DogeDark approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@DogeDark DogeDark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Once 0.5 is out, bump the versions and we can merge.

(If you wanted my thoughts on the map_err or ok_or, I don't think it matters too much - they seem pretty similar)

@marc2332
Copy link
Collaborator Author

(If you wanted my thoughts on the map_err or ok_or, I don't think it matters too much - they seem pretty similar)

Idk, I changed it because the CI was failing 😂, I think some new rust update changed it or something

@ealmloff ealmloff mentioned this pull request Mar 28, 2024
Merged
@DogeDark
Copy link
Member

Thank you!!

@DogeDark DogeDark merged commit dbd7f55 into DioxusLabs:master Mar 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DogeDark DogeDark DogeDark approved these changes

Assignees
No one assigned
Labels
waiting on next dioxus release Waiting on the next Dioxus release before action.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marc2332 @DogeDark