From d2da1b9ab000d06abde76e9a857bbe5895b33c5a Mon Sep 17 00:00:00 2001 From: Jason Erb Date: Sat, 11 Feb 2023 22:45:41 -0500 Subject: [PATCH] Treat V8 platform symbols same as base This exports V8 platform symbols in the Node shared library build. --- tools/v8_gypfiles/v8.gyp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp index ba8b161f0ffa77..e9f3505eeb193a 100644 --- a/tools/v8_gypfiles/v8.gyp +++ b/tools/v8_gypfiles/v8.gyp @@ -1339,10 +1339,7 @@ '<(V8_ROOT)/src/libplatform/worker-thread.h', ], 'conditions': [ - ['component=="shared_library"', { - 'direct_dependent_settings': { - 'defines': ['USING_V8_PLATFORM_SHARED'], - }, + ['is_component_build', { 'defines': ['BUILDING_V8_PLATFORM_SHARED'], }], ['v8_use_perfetto==1', {