Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Arch ARM #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixes for Arch ARM #5

wants to merge 5 commits into from

Conversation

pldemone
Copy link

@pldemone pldemone commented Jan 6, 2016

Small fixes for Arch ARM and documenation changes

  • Use tcflush() instead fsync() for data synchronization
  • Set correct return type for getopt_long()
  • "-lrt" shared linker flags added to CMakeLists.txt
  • Short compile/cross-compile description added

@DocLambda
Copy link
Owner

The changes look fine except the "Use tcflush() instead fsync() for data synchronization" (f16a7b1) one. Please see my comment above.
Could you please prepare a pull request without f16a7b1!?

@pldemone
Copy link
Author

Sure, but it will take some time because I'm out of office. Please note that fsync() is not working on many ARM platforms (probably RPi too) and the code will generate an error during execution. I my case it was intended to discard the queue to avoid a resend of invalid valid data and hitting a timeout. But I see that this solution was bogus for your platform.

@DocLambda
Copy link
Owner

Can you please give some pointers documenting that fsync is not working on ARM!? What is the exact error message? However, the best we can probably do is to test if the platform has a working fsync during configure (cmake) and ifdef out the calls to fsync otherwise...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants