FIX : bad test on socid #27353
Open
FIX : bad test on socid #27353
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
never work if no user id send (aka -1 on first param)
eldy
reviewed
Jan 10, 2024
eldy
added
the
PR to fix - See feedback in comments
eldy
reviewed
Jan 10, 2024
| $sql .= " AND f.fk_soc = ".((int) $socid); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
This seems to break the case when $socid = -1, where we should not have any test in such a case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
never work if no user id send (aka -1 on first param)