fix/feat: ProductLot document folder have to be the rowid #29859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ev_fix_folder_for_product_lot
…libarr into dev_fix_folder_for_product_lot
…ev_fix_folder_for_product_lot
eldy
reviewed
Jul 18, 2024
| @@ -596,7 +596,7 @@ | |||
| // Documents | |||
| if ($includedocgeneration) { | |||
| $objref = dol_sanitizeFileName($object->ref); | |||
| $relativepath = $objref.'/'.$objref.'.pdf'; | |||
| $relativepath = $object->id.'/'.$objref.'.pdf'; | |||
There was a problem hiding this comment.
Using id may be a problem when doing export/import
Id may change. Restoring directory of a backup for exemple
will be not sync with restore
This is why we use ref.
Is it possible to use productref_batchnumber instead of batch number ? (I think it is the real key of a batch number)
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem with not implement stritly with ID, when user create ref lot that can be look like id
Exemple
On lot ref 5300, upload a file, the file is store in "document"/productlot/5538/file.test
=> Directory name is rowid of lot ref( "document"/productlot/5538/file.test), that what we want as lot ref is not unique (unique key on ref lot(column batch)/product)
On lot ref 4883, upload a file, the file is store in "document"/productlot/5300/file.test1
Go back on lot ref 5300, you see the file /productlot/5300/file.test1 instead of 5538/file.test