forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Discover] fix auto-refresh (elastic#80635)
* fix refresh interval in discover * Also implicitly fixes a subtle bug with excessive re-fetch after deleting already disabled filter Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
- Loading branch information
1 parent
ee7ae63
commit 7f5c656
Showing
6 changed files
with
113 additions
and
18 deletions.
There are no files selected for viewing
52 changes: 52 additions & 0 deletions
52
src/plugins/data/public/query/query_string/query_string_manager.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { QueryStringManager } from './query_string_manager'; | ||
import { Storage } from '../../../../kibana_utils/public/storage'; | ||
import { StubBrowserStorage } from 'test_utils/stub_browser_storage'; | ||
import { coreMock } from '../../../../../core/public/mocks'; | ||
import { Query } from '../../../common/query'; | ||
|
||
describe('QueryStringManager', () => { | ||
let service: QueryStringManager; | ||
|
||
beforeEach(() => { | ||
service = new QueryStringManager( | ||
new Storage(new StubBrowserStorage()), | ||
coreMock.createSetup().uiSettings | ||
); | ||
}); | ||
|
||
test('getUpdates$ is a cold emits only after query changes', () => { | ||
const obs$ = service.getUpdates$(); | ||
const emittedValues: Query[] = []; | ||
obs$.subscribe((v) => { | ||
emittedValues.push(v); | ||
}); | ||
expect(emittedValues).toHaveLength(0); | ||
|
||
const newQuery = { query: 'new query', language: 'kquery' }; | ||
service.setQuery(newQuery); | ||
expect(emittedValues).toHaveLength(1); | ||
expect(emittedValues[0]).toEqual(newQuery); | ||
|
||
service.setQuery({ ...newQuery }); | ||
expect(emittedValues).toHaveLength(1); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters