Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate field names in the Json have incorrect comments, and nested classes from Config cannot be outside the Config class #22

Open
spoorn opened this issue Aug 1, 2022 · 0 comments · May be fixed by #21
Open

Duplicate field names in the Json have incorrect comments, and nested classes from Config cannot be outside the Config class #22

spoorn opened this issue Aug 1, 2022 · 0 comments · May be fixed by #21

Comments

@spoorn
Copy link

spoorn commented Aug 1, 2022

Was trying to use OmegaConfig instead of Cloth Config for my mod (https://www.curseforge.com/minecraft/mc-mods/spoorn-bounty-mobs), due to issues with Lists and Maps always reverting to default values: shedaniel/cloth-config#104.

Noticed that nested config classes are only supported if they are inner static classes of the root Config class which would be annoying refactoring for me.

Also noticed that duplicate field names in the Json would cause incorrect comments because the OmegaConfig logic does not take into account that scenario and just overrides with the last comment for a field name

I already submitted a PR to fix this: #21, but putting up an Issue so it's more easily searchable in case others run into the same problem
@spoorn spoorn linked a pull request Aug 1, 2022 that will close this issue
Open
spoorn added a commit to spoorn/SpoornBountyMobs that referenced this issue Aug 1, 2022
@spoorn
Switch to OmegaConfig to fix issues with Lists and Maps:
ba9a115 
shedaniel/cloth-config#104

Adds custom logic for saving OmegaConfig configs until
Draylar/omega-config#22 gets resolved
spoorn added a commit to spoorn/SpoornBountyMobs that referenced this issue Aug 1, 2022
@spoorn
Switch to OmegaConfig to fix issues with Lists and Maps:
a831622 
shedaniel/cloth-config#104

Adds custom logic for saving OmegaConfig configs until
Draylar/omega-config#22 gets resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@spoorn