Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change directory before running git command #754

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

nashcft
Copy link
Contributor

@nashcft nashcft commented Sep 25, 2022

Issue

Overview (Required)

The cause of error reported in #734 is running git command out of git repository. This occurs because current directory when the step Delete old branch saving screenshots is executed is $GITHUB_WORKSPACE although the checked-out repository is located on $GITHUB_WORKSPACE/temp_docs.
The step worked fine before workflow was split in #723 because the base workflow (ScreenShotTest) also checked-out repository on $GITHUB_WORKSPACE to run screenshot tests.

This PR added a change-directory command at the beginning of commands executed in Delete old branch saving screenshots. The PR also tried to make destinations of change-directory operations clear with the default environment variable $GITHUB_WORKSPACE.

Links

N/A

Screenshot

N/A

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 25, 2022 12:25 Inactive
@takahirom takahirom merged commit e042bb3 into DroidKaigi:main Sep 25, 2022
@takahirom
Copy link
Member

Great!

@nashcft
Copy link
Contributor Author

nashcft commented Sep 25, 2022

now I'll open a test pull request 🏃

@nashcft nashcft deleted the fix-comment-layout-diff-action branch September 25, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants