Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Improve the language setting detection #769

Merged
merged 1 commit into from
Sep 27, 2022
Merged

[iOS] Improve the language setting detection #769

merged 1 commit into from
Sep 27, 2022

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Sep 26, 2022

Issue

  • N/A

Overview (Required)

  • This PR changes to check the language code instead of the country code for a better language setting detection

Links

Screenshot

Before After

Language: English - Region: Japan
Language: English - Region: Japan

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 26, 2022 17:35 Inactive
ry-itto
ry-itto approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks 👍🏼

@ry-itto ry-itto merged commit dd8cd42 into DroidKaigi:main Sep 27, 2022
@woxtu woxtu deleted the language-setting branch September 27, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry-itto ry-itto ry-itto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woxtu @ry-itto