♻️ Update Enable transition from session details to the search screen. #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
deploygate-distribution
github-actions
bot
temporarily deployed
to
deploygate-distribution
takahirom
reviewed
Sep 29, 2022
| @@ -99,6 +100,10 @@ fun SearchRoot( | |||
|
|
|||
| val keyboardController = LocalSoftwareKeyboardController.current | |||
|
|
|||
| if (categoryId != null) { | |||
| viewModel.onCategorySelected(categoryId) | |||
There was a problem hiding this comment.
I think we shouldn't call viewModel moethod in Composable function directly. 👀
So how about using LaunchedEffect?
LaunchedEffect(initialCategoryId) {
viewModel.onCategorySelected(categoryId)
}
takahirom
reviewed
Sep 29, 2022
| viewModel.onCategorySelected(categoryId) | ||
| LaunchedEffect(categoryId) { | ||
| if (categoryId != null) { | ||
| viewModel.onCategorySelected(categoryId) |
There was a problem hiding this comment.
Sorry, can we use initialCategoryId instead of categoryId? Because it is used only for the initial state.
github-actions
bot
temporarily deployed
to
deploygate-distribution
|
Thanks! LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Movie
before.mp4
after.mp4