Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update: using downloadablefont instead of local file" #838

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

Luecy1
Copy link
Contributor

@Luecy1 Luecy1 commented Oct 3, 2022

Issue

Overview (Required)

  • Two lines may not be displayed due to downloadable font
  • Reverted to use local files instead of downloadable fonts

Links

Screenshot

Before After

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

There are differences in Compose previews:

@takahirom
Copy link
Member

Please run spotlessApply 🙏
And there are preview changes. This is because downloadable fonts are not applied when previewing, right?

@Luecy1
Copy link
Contributor Author

Luecy1 commented Oct 4, 2022

run & push deone.

About the preview
I'm not sure downloadable fonts are applied in the preview. Sorry...
I think it was probably applied because I made it use a local font.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

There are differences in Compose previews:

@github-actions github-actions bot temporarily deployed to deploygate-distribution October 4, 2022 12:00 Inactive
@takahirom
Copy link
Member

Thanks for addressing the problem!

@takahirom takahirom merged commit b599f91 into DroidKaigi:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary ellipsis appear on the time-line title
2 participants