Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump target sdk version to 33 #842

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

NUmeroAndDev
Copy link
Collaborator

@NUmeroAndDev NUmeroAndDev commented Oct 4, 2022

Issue

  • close #ISSUE_NUMBER

Overview (Required)

  • Updated target sdk version.
  • Implemented notification permission.

Links

Screenshot

  • when allowed permission
device-2022-10-04-144451.mp4
  • when rejected permission
device-2022-10-04-144331.mp4
  • show notification
device-2022-10-04-152424.mp4

PackageInfoFlags.of(0)
)
} else {
context.packageManager.getPackageInfo(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takahirom
Copy link
Member

Can you check session alarm?👀

@NUmeroAndDev
Copy link
Collaborator Author

I forgot to implement notification permission. 😅
I thinks to implement display it when the app launched.

@github-actions github-actions bot temporarily deployed to deploygate-distribution October 4, 2022 05:32 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution October 4, 2022 07:46 Inactive
@NUmeroAndDev
Copy link
Collaborator Author

Added missing notification permission implementation. 🙏

@takahirom takahirom merged commit 59bb7e4 into DroidKaigi:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants