Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring] Remove unused variable from Hours #879

Conversation

rkowase
Copy link
Contributor

@rkowase rkowase commented Oct 7, 2022

Issue

  • n/a

Overview (Required)

In this PR, I removed unused variable from Hours to fix a lint warning.
I'm not sure anyone plan to use this unused right variable in the future, but I think it should be removed for now as YAGNI principal.

Links

  • n/a

Screenshot

スクリーンショット 2022-10-07 14 21 32

@rkowase rkowase marked this pull request as ready for review October 7, 2022 05:40
@github-actions github-actions bot temporarily deployed to deploygate-distribution October 7, 2022 08:11 Inactive
@takahirom
Copy link
Member

Looks good!

@takahirom takahirom merged commit 8e54bfb into DroidKaigi:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants