Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for AboutScreenRobot to assert AuxiliaryInformation #889

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Add test cases for AboutScreenRobot to assert AuxiliaryInformation #889

merged 1 commit into from
Oct 8, 2022

Conversation

rkowase
Copy link
Contributor

@rkowase rkowase commented Oct 7, 2022 •
edited
Loading

Issue

  • n/a

Overview (Required)

In this PR, I added test cases for AboutScreenRobot to make sure that the below elements are visible.

  • Access
  • Staff List
  • License
  • Code Conduct
  • Privacy Policy
  • App Version

Links

  • n/a

Screenshot

Before After
No changes (same as before)

The test has been passed locally. ✅
スクリーンショット 2022-10-07 16 25 12

@rkowase rkowase marked this pull request as ready for review October 7, 2022 07:25
@rkowase rkowase changed the title Add test cases for AboutScreenRobot Add test cases for AboutScreenRobot to assert AuxiliaryInformation Oct 7, 2022
@github-actions github-actions bot temporarily deployed to deploygate-distribution October 7, 2022 12:45 Inactive
takahirom
takahirom approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I think we don't have to check everything. But I think these features are important. So I think it is good!

@takahirom takahirom merged commit 9fbaaea into DroidKaigi:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkowase @takahirom