-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added color theming #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...system/src/androidMain/kotlin/io/github/droidkaigi/confsched2022/designsystem/theme/Color.kt
Outdated
Show resolved
Hide resolved
NUmeroAndDev
force-pushed
the
add_color_theming
branch
from
August 30, 2022 01:15
3b557dc
to
5704267
Compare
takahirom
reviewed
Aug 30, 2022
...system/src/androidMain/kotlin/io/github/droidkaigi/confsched2022/designsystem/theme/Color.kt
Outdated
Show resolved
Hide resolved
takahirom
reviewed
Aug 30, 2022
...system/src/androidMain/kotlin/io/github/droidkaigi/confsched2022/designsystem/theme/Color.kt
Outdated
Show resolved
Hide resolved
NUmeroAndDev
force-pushed
the
add_color_theming
branch
from
September 2, 2022 11:29
5704267
to
e081c76
Compare
const val neutralVariantKeyColor95 = 0xFFEAF3EA | ||
const val neutralVariantKeyColor99 = 0xFFF6FFF6 | ||
const val neutralVariantKeyColor100 = 0xFFFFFFFF | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[spotless] reported by reviewdog 🐶
Suggested change
} | |
} |
NUmeroAndDev
force-pushed
the
add_color_theming
branch
from
September 2, 2022 11:41
e081c76
to
22bae22
Compare
takahirom
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your great advices and corporation🎨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot