fix(ci/cd): Fix QA CI pipeline bug #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_home_page #109 Enhancement for explorer home page
* #66 initial article commit * #66: Refactor article page, fetch article metadata Moved Article.vue, separated out into article.js to match file structure of other pages. Progressed on Semantic Scholar API logic. * #66: Refactor article.js * #66: Refactor Article.vue * #66: Add route for Article View Added route to explorer for the article view. Moved DOI from component prop to a watcher and computed property pair. * #66: Refactor article.js to move logic to services Moved article metadata retrieval logic to services. Unified all metadata under one object for simpler reference. * #66: First pass at article HTML view First attempt at displaying all article metadata. Also added pre-push linting fixes. * #66: Add loading state awareness * #66: Add article venue to retrieved fields * #66: Second pass at article view HTML Added basic loading indicator, refactored table to have better structure (I think) * #66: Basic CSS for article view * #66: Removed erroneous comment * #66: Fix scrolling bug Scrolling tables also scrolled their titles, but not their header rows. Isolated tables in their own div, maybe tables should be their own component... * #66: Unify dir structure, nest article page Move explorer/article/services to modules/explorer/article/services, clean up article now that it's nested properly (barring further change to nest completely under sample). Refactor extra function from fetchJSON into getArticleMetadata. * #66: initial Article.vue testing commit Includes mock for Semantic Scholar API calls and article.js whitespace linting fix. * #66: Refactored getArticleMetadata for easier mock Mocking getArticleMetadata easily required moving it into an enclosing object so that the manual mock could do the same, allowing it to access properties. The manual mock was written following along with [jest's manual mock](https://jestjs.io/docs/manual-mocks). The mock of the resulting getArticle also provides a stub of the SemanticScholar API response as of 2/2/22, for reference and testing. * #66: Write tests for Article.vue Wrote tests of DOI loading, reloading; article data loading; API failure. Added classes to article.html items to distinguish them and allow the tests to refer to them. Updated article.js to use the new articleMetadata.js and fixed bugs that appeared in testing. * #66: Fix linting errors * #66: Write tests for module articleMetadata.js Updated articleMetadata mock to include raw and cleaned mock data, and wrote tests of the fetch handler and response cleaning routines. Fixed issues in articleMetadata.js that came up in testing. * #66: Refactored articleMetadata.js to better track API errors Refactored .get function to remove repeated code and allow API calls to occur in parallel. Rewrote how internal fetch returns in order to pass errors (and success codes) in API call along to caller. Updated mock data to include mock version of success codes * #66: Updated tests to match Also added missing response codes to mock data, and fixed citation and reference call status not being passed through * #66: Updated Article.vue to display errors Article view now takes advantage of newly passed API errors to inform the user that an error has occurred. This could be expanded on * #66: Linting fixes * #66: Update test to use createWrapper Replaced localVue, shallowMount with createWrapper for consistency. Added test to ensure error message is displayed to user. * #66: Write comments, refactor error storage * #66: Write jsdoc-style function comments Documented functions, removed unused mock response function, and refactored testing slightly to remove repetition. * #66: Move article to its own route * #25: Remove console.logs, add reusable spinner
#97 Header Tab Panel
…_Sample RFC(#113): refactor templated view sample
…into #229_spreadsheet_file_interface
* #207: Update unit test to run in band * #207: Update to remove facet dialog for smaller screen * #207: Add materials property to facet search * #207, #212: Total count fix and added materials property fetch actions * #207: Remove facet call at home page load * #207: Refactor BE api to support materials property functionality on UI * #207: Backend unit testing for admin controller apis * #207: Added unit test for materials property and searchtableresult component * #207: Linter and error fixes * #207: Fix import typo * #207: Upgrade node version * #207: Refactor name to * :bug #207: Update CI node version * 🐛 #207: Downgrade CI node version
…into #229_spreadsheet_file_interface
#229 Spreadsheet File Interface
Update readme ICO
* #293: Add coverage to gitignore and update readme icon * #293: Fixed parameterized query UI inconsistency * #293: Sticky header bug fix * #293: Update unit test for viz page * #293: Add new filter types and removed undefined from image response * #293: Refactor auth middleware to use the centralized error writer * 293: Add 404 controller to backend to manage unavailable routes and page not found * #293: Fix mobile bug in viz page * #293: Update to return authors as part of image response
* #300: Add names for each container * 🔥[hotfix]: FE Bug fixes * 🔥[hotfix]: Linter fixes * #300: BE auth service setup * #300: Refactor FE with auth flow implementation * #300: Add auth service to proxy * #300: Update docker environment variables * #300: Linter fix * #300: Refactor failing component and fix test failures * #300: Fixed merged conflict * #300: Add additional logger to auth service * #300: Add additional logger to auth service * #300: Remove unused logger from auth service * #300: Remove unused logger from auth service * #300: Update failed auth response * #300: Refactor login button * #300: Remove sparql query menu * #300: Update logout actions * #300: Update unit test assertions * #300: Remove skipped unit test
…into #292_visualization_gallery_ui_bugs
* feat(upgrade): #309 Add rest coverage report to gitignore * feat(upgrade): #309 Setup coverage testing report for backend * feat(core): #309 Add release versioning to CI pipeline * feat(ci/cd): #309 Update CI pipeline for prod release * feat(ci/cd): #309 Re-enabled image build and deployment for QA CI environment
make the page number input smaller to match surrounding labels, move the selection to the same line as buttons and match styling
…i_bugs fix(#292): update visualization image gallery
…uest approval (#311)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix QA CI pipeline bug