Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): #333 Valid Curation List Item Page #334

Merged
merged 17 commits into from
Mar 12, 2023
Merged

feat(core): #333 Valid Curation List Item Page #334

merged 17 commits into from
Mar 12, 2023

Conversation

tholulomo
Copy link
Contributor

This PR completes the following task:

  • Validation list item UI page
  • Backend implementation - POST, UPDATE, & GET
  • Mongoose model
  • Valid curation list item frontend and backend unit testing

closes #333

tholulomo and others added 10 commits March 8, 2023 21:05
@tholulomo tholulomo added the P2 🥈 Priority 2 label Mar 10, 2023
@tholulomo tholulomo self-assigned this Mar 10, 2023
aswallace
aswallace approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@aswallace aswallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions, otherwise looks good

app/src/assets/css/modules/_pages.scss Outdated Show resolved Hide resolved
app/src/assets/css/modules/_utility.scss Outdated Show resolved Hide resolved
app/src/components/explorer/Header.vue Show resolved Hide resolved
app/src/pages/explorer/curate/validlist/UpdateXlsList.vue Outdated Show resolved Hide resolved
app/src/pages/explorer/curate/validlist/UpdateXlsList.vue Outdated Show resolved Hide resolved
app/src/pages/explorer/curate/validlist/XlsList.vue Outdated Show resolved Hide resolved
@tholulomo tholulomo merged commit 1037d43 into develop Mar 12, 2023
@tholulomo tholulomo deleted the #333_XLS_VALIDATION_LIST branch March 12, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswallace aswallace aswallace approved these changes

Assignees

@tholulomo tholulomo

Labels
P2 🥈 Priority 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XLS validation list
2 participants
@tholulomo @aswallace