Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate foxglove #22

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Migrate foxglove #22

wants to merge 16 commits into from

Conversation

maxwellmlin
Copy link
Member

@maxwellmlin maxwellmlin commented Nov 24, 2024

  • Bump ros-typescript-generator to 1.9.0
  • Generate all ROS 2 interfaces at build time (instead of relying on commited file which may be outdated)
    • Note: this means foxglove.py must be run inside the container
  • Use smartEnums for ros-typescript-generator.

Before:

export enum CustomMsgsPidGainConst {
  LOOP_POSITION = 0,
  LOOP_VELOCITY = 1,
  AXIS_X = 0,
  AXIS_Y = 1,
  AXIS_Z = 2,
  AXIS_ROLL = 3,
  AXIS_PITCH = 4,
  AXIS_YAW = 5,
  GAIN_KP = 0,
  GAIN_KI = 1,
  GAIN_KD = 2,
  GAIN_FF = 3,
}

After:

export enum CustomMsgsPidGainLoop {
  POSITION = 0,
  VELOCITY = 1,
}

export enum CustomMsgsPidGainAxis {
  X = 0,
  Y = 1,
  Z = 2,
  ROLL = 3,
  PITCH = 4,
  YAW = 5,
}

export enum CustomMsgsPidGainGain {
  KP = 0,
  KI = 1,
  KD = 2,
  FF = 3,
}

@maxwellmlin maxwellmlin linked an issue Nov 24, 2024 that may be closed by this pull request
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Foxglove
1 participant