fates interface: integration of external model #1531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his passes the flag -bgc ed -no-megan to the namelist generation script. Later changes should update this to FATES, however there are string lenth limitations in place that have to be identified first. continued work on fates-BGC interface, specifically cold-start initialization for carbon flux and state vars, and not allocating memory in patch-level carbon flux and state vars FATES integration: removed provisional fates-side interface call. Also, copied in the wrappers used on CLM side in the fates developer repository. fates interface: incremental progress towards bringing in the clmfates interface wrappers and the fates submodule. FATES-interface: Debugging newly attached interface. Included the removal of duplicate history fields that showed up in native CN vegetation and FATES, such as NEP. Fixed call order of fates parameters. Fates interface: fixed call order of fates dynamics, cleaned out some of the use_ed filtering that occurs in history and summary during CNCarbonState and CNCarbonflux. FATES-interface: Shuffled around the call order of FATES parameter reads. FATES-inteface: Partitioned the summary variables in soil bgc used during fates calls, as well as history initialization. FATES-interface: renamed EDBGCDyn to FatesBGCDyn. FATES-interface: modified the test user nl
…d deprecated variables
…preprocessor file. These new functions are required for the fates parameter interface.
|
closing, re-naming the submitting branch and re-submitting. |
jgfouca
pushed a commit
that referenced
this pull request
Jun 2, 2017
add ability to remove tabs in shr_string_lalign Removal of tabs from strings in stream files Test suite: scripts_regression_tests also manual verification that if tabs were introduced in a streams text file (e.g. datm.streams.txt.CORE2_NYF.GISS) then the resulting data model behaved correctly Test baseline: Test namelist changes: Test status: bit for bit Fixes #862 User interface changes?: None Code review:sacks, edwards,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set completes a first version of 1) the ALM-side interface for FATES, 2) initializes FATES as a submodule and 3) adds a test to acme_land_developer. Restart simulations, while having the code in place, are not passing tests yet and will be addressed in forthcoming changesets. Modifications to the namelist build system were necessary. Thus, there are trivial conflicts with namelists generated by master, specifically use_ed=.false. is now appended to all namelists where it is not used. This has no impact on existing tests' model output, however CLM regression tests will fail namelist comparisons for this reason. As this PR initializes a new submodule, all CLM users must update their submodule pointers to bring the fates codeset in, without this the code will not compile.