-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in DoD onyx mods #3100
Merge in DoD onyx mods #3100
Changes from all commits
e725c80
6a2d2ea
b6d0120
1271f4b
9443fcf
f956fd5
bebf06d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -163,13 +163,15 @@ | |
<config_use_standardGM ocn_grid="oRRS18to6">.false.</config_use_standardGM> | ||
<config_use_standardGM ocn_grid="oRRS18to6v3">.false.</config_use_standardGM> | ||
<config_use_standardGM ocn_grid="oRRS15to5">.false.</config_use_standardGM> | ||
<config_use_standardGM ocn_grid="oARRM60to10">.false.</config_use_standardGM> | ||
<config_use_standardGM ocn_grid="oARRM60to6">.false.</config_use_standardGM> | ||
<config_use_standardGM ocn_grid="oARRM60to10">.true.</config_use_standardGM> | ||
<config_use_standardGM ocn_grid="oARRM60to6">.true.</config_use_standardGM> | ||
<config_use_Redi_surface_layer_tapering>.false.</config_use_Redi_surface_layer_tapering> | ||
<config_Redi_surface_layer_tapering_extent>0.0</config_Redi_surface_layer_tapering_extent> | ||
<config_use_Redi_bottom_layer_tapering>.false.</config_use_Redi_bottom_layer_tapering> | ||
<config_Redi_bottom_layer_tapering_depth>0.0</config_Redi_bottom_layer_tapering_depth> | ||
<config_GM_Bolus_kappa_function>'constant'</config_GM_Bolus_kappa_function> | ||
<config_GM_Bolus_kappa_function ocn_grid="oARRM60to10">'ramp'</config_GM_Bolus_kappa_function> | ||
<config_GM_Bolus_kappa_function ocn_grid="oARRM60to6">'ramp'</config_GM_Bolus_kappa_function> | ||
<config_standardGM_tracer_kappa>1800.0</config_standardGM_tracer_kappa> | ||
<config_standardGM_tracer_kappa ocn_grid="oEC60to30v3wLI" ocn_forcing="datm_forced_restoring" >600.0</config_standardGM_tracer_kappa> | ||
<config_GM_Bolus_kappa_min>0.0</config_GM_Bolus_kappa_min> | ||
|
@@ -440,14 +442,20 @@ | |
<config_use_activeTracers>.true.</config_use_activeTracers> | ||
<config_use_activeTracers_surface_bulk_forcing>.true.</config_use_activeTracers_surface_bulk_forcing> | ||
<config_use_activeTracers_surface_restoring>.false.</config_use_activeTracers_surface_restoring> | ||
<config_use_activeTracers_surface_restoring ocn_grid="oARRM60to10">.true.</config_use_activeTracers_surface_restoring> | ||
<config_use_activeTracers_surface_restoring ocn_grid="oARRM60to6">.true.</config_use_activeTracers_surface_restoring> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these should not be default because we only do restoring in G-cases. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will back out all of the changes to the mpaso namelist_defaults. I think that is more consistent with the overall strategy of using user_nl_mpaso to set things up and the benefit is the namelist defaults file remains consistent with master. |
||
<config_use_activeTracers_interior_restoring>.false.</config_use_activeTracers_interior_restoring> | ||
<config_use_activeTracers_exponential_decay>.false.</config_use_activeTracers_exponential_decay> | ||
<config_use_activeTracers_idealAge_forcing>.false.</config_use_activeTracers_idealAge_forcing> | ||
<config_use_activeTracers_ttd_forcing>.false.</config_use_activeTracers_ttd_forcing> | ||
<config_use_surface_salinity_monthly_restoring>.false.</config_use_surface_salinity_monthly_restoring> | ||
<config_use_surface_salinity_monthly_restoring ocn_grid="oARRM60to10">.true.</config_use_surface_salinity_monthly_restoring> | ||
<config_use_surface_salinity_monthly_restoring ocn_grid="oARRM60to6">.true.</config_use_surface_salinity_monthly_restoring> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment as above There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment as above. |
||
<config_surface_salinity_monthly_restoring_compute_interval>'0000-00-01_00:00:00'</config_surface_salinity_monthly_restoring_compute_interval> | ||
<config_salinity_restoring_constant_piston_velocity>1.585e-6</config_salinity_restoring_constant_piston_velocity> | ||
<config_salinity_restoring_max_difference>0.5</config_salinity_restoring_max_difference> | ||
<config_salinity_restoring_max_difference ocn_grid="oARRM60to10">100.</config_salinity_restoring_max_difference> | ||
<config_salinity_restoring_max_difference ocn_grid="oARRM60to6">100.</config_salinity_restoring_max_difference> | ||
<config_salinity_restoring_under_sea_ice>.false.</config_salinity_restoring_under_sea_ice> | ||
|
||
<!-- tracer_forcing_debugTracers --> | ||
|
@@ -817,6 +825,8 @@ | |
|
||
<!-- AM_eddyProductVariables --> | ||
<config_AM_eddyProductVariables_enable>.false.</config_AM_eddyProductVariables_enable> | ||
<config_AM_eddyProductVariables_enable ocn_grid="oARRM60to10">.true.</config_AM_eddyProductVariables_enable> | ||
<config_AM_eddyProductVariables_enable ocn_grid="oARRM60to6">.true.</config_AM_eddyProductVariables_enable> | ||
<config_AM_eddyProductVariables_enable ocn_grid="oRRS30to10v3">.true.</config_AM_eddyProductVariables_enable> | ||
<config_AM_eddyProductVariables_enable ocn_grid="oRRS30to10v3wLI">.true.</config_AM_eddyProductVariables_enable> | ||
<config_AM_eddyProductVariables_enable ocn_grid="oRRS18to6v3">.true.</config_AM_eddyProductVariables_enable> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,8 @@ add_default($nl, 'config_full_abort_write'); | |
# Namelist group: decomposition # | ||
################################# | ||
|
||
add_default($nl, 'config_block_decomp_file_prefix', 'val'=>"'${DIN_LOC_ROOT}/ice/mpas-cice/${ICE_GRID}/mpas-cice.graph.info.${date_stamp}.part.'"); | ||
#add_default($nl, 'config_block_decomp_file_prefix', 'val'=>"'${DIN_LOC_ROOT}/ice/mpas-cice/${ICE_GRID}/mpas-cice.graph.info.${date_stamp}.part.'"); | ||
add_default($nl, 'config_block_decomp_file_prefix', 'val'=>"'${DIN_LOC_ROOT}/ice/mpas-cice/${ICE_GRID}/mpas-seaice.graph.v2.${date_stamp}.part.'"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could you please explain this change? Shouldn't the default be the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have reviewed this and will remove it. I just grepped for graph in the mpas-seaice stuff and made changes in all places that seemed appropriate. I have now looked at the implementation and agree this should be left unchanged. |
||
add_default($nl, 'config_number_of_blocks'); | ||
add_default($nl, 'config_explicit_proc_decomp'); | ||
add_default($nl, 'config_proc_decomp_file_prefix'); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to add these changes for a specific machine. Also, @apcraig: we should talk about the improvements you experienced with these settings (we can do this by email).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I will take care of that.