Add explicit types to literals in COARE ocean surface flux scheme #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The COARE ocean surface flux scheme had a large number of un-typed literals (including some in functions that caused a build issue on Summit). This change converts most to "_R8". This shouldn't affect the climate of "out of the box" cases (which use a different ocean surface flux scheme), but may be non-BFB with the original COARE implementation. This needs to be tested. [BFB] - Bit-For-Bit ? [FCC] - Flag Climate Changing Issue number 3105
JackReevesEyre
added
bug fix PR
BFB
|
This commit has been tested on Summit (@dqwu) and fixed the IBM XL compiler build failures. It has been tested on Anvil with the COARE scheme active (i.e., ocn_surface_flux_scheme = 1 in user_nl_cpl): it built and ran successfully but gave different answers to the pre-bug fix version (due to changed types/kinds of some constants). |
rljacob
approved these changes
Aug 28, 2019
|
@kaizhangpnl @singhbalwinder |
kaizhangpnl
approved these changes
Sep 17, 2019
|
Sorry, I missed the notification (to review the commit). Just approved it. |
|
Thanks! I will merge it today. |
singhbalwinder
added a commit
that referenced
this pull request
Sep 19, 2019
Add explicit types to literals in COARE ocean surface flux scheme The COARE ocean surface flux scheme had un-typed literals (including some in functions that caused a build issue on Summit). This change adds explicit types - in most cases converting to "_R8" reals. This shouldn't affect the climate of "out of the box" cases (which use a different ocean surface flux scheme). But, when using the COARE scheme (ocn_surface_flux_scheme = 1 in user_nl_cpl), it is non-BFB with the earlier COARE implementation. Fixes #3105 [BFB] [FCC] * jackreeveseyre/cime/sfc_flux_bug_fix: Adds explicit types to literals in COARE ocean surface flux scheme.
|
Pushed to next |
singhbalwinder
added a commit
that referenced
this pull request
Sep 20, 2019
Add explicit types to literals in COARE ocean surface flux scheme The COARE ocean surface flux scheme had un-typed literals (including some in functions that caused a build issue on Summit). This change adds explicit types - in most cases converting to "_R8" reals. This shouldn't affect the climate of "out of the box" cases (which use a different ocean surface flux scheme). But, when using the COARE scheme (ocn_surface_flux_scheme = 1 in user_nl_cpl), it is non-BFB with the earlier COARE implementation. Fixes #3105 [BFB] [FCC] * jackreeveseyre/cime/sfc_flux_bug_fix: Adds explicit types to literals in COARE ocean surface flux scheme.
minxu74
added a commit
that referenced
this pull request
Sep 20, 2019
With PR #3153 and #3184 locally merged for testing, there are still build errors reported by IBM XL compiler on Summit. This PR fixes the following build errors for IBM compiler: 1511-077 (E) ELSEWHERE statement is in error. 1513-041 (S) Arguments of the wrong type were specified for the INTRINSIC procedure "max". 1515-019 (S) Syntax is incorrect. 1515-021 (E) Syntax error: Token " & " is expected. 1515-022 (S) Syntax Error: Extra token " , " was found. [BFB] * dqwu/fixes_for_summit: Fixing some build errors for IBM XL compiler on Summit
minxu74
added a commit
that referenced
this pull request
Sep 23, 2019
With PR #3153 and #3184 locally merged for testing, there are still build errors reported by IBM XL compiler on Summit. This PR fixes the following build errors for IBM compiler: 1511-077 (E) ELSEWHERE statement is in error. 1513-041 (S) Arguments of the wrong type were specified for the INTRINSIC procedure "max". 1515-019 (S) Syntax is incorrect. 1515-021 (E) Syntax error: Token " & " is expected. 1515-022 (S) Syntax Error: Extra token " , " was found. [BFB]
rljacob
pushed a commit
that referenced
this pull request
May 6, 2021
Add explicit types to literals in COARE ocean surface flux scheme The COARE ocean surface flux scheme had un-typed literals (including some in functions that caused a build issue on Summit). This change adds explicit types - in most cases converting to "_R8" reals. This shouldn't affect the climate of "out of the box" cases (which use a different ocean surface flux scheme). But, when using the COARE scheme (ocn_surface_flux_scheme = 1 in user_nl_cpl), it is non-BFB with the earlier COARE implementation. Fixes #3105 [BFB] [FCC] * jackreeveseyre/cime/sfc_flux_bug_fix: Adds explicit types to literals in COARE ocean surface flux scheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The COARE ocean surface flux scheme had un-typed literals (including some in functions that caused a build issue on Summit). This change adds explicit types - in most cases converting to "_R8" reals. This shouldn't affect the climate of "out of the box" cases (which use a different ocean surface flux scheme). But, when using the COARE scheme (ocn_surface_flux_scheme = 1 in user_nl_cpl), it is non-BFB with the earlier COARE implementation.
Fixes #3105
[BFB] [FCC]