bug fix for SCM time index #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlin7
approved these changes
Sep 3, 2019
wlin7
added a commit
that referenced
this pull request
Sep 3, 2019
Bug fix for SCM time index for forcing data This bug fix effects single column model (SCM) cases when the temporal resolution of the forcing is different than that of E3SM. Here the index "i" in the iteration loop to find the next available forcing is redundant and can result in forcing being read in with a time step lag. Also cleaned up the print statements to the E3SM logs to make them more verbose and to print out the correct values. All E3SM developer tests pass, except SMS_R_Ld5.ne4_ne4.FSCM5A97, which is an expected fail [BFB] except for the SCM test.
|
Merged to next. |
wlin7
added a commit
that referenced
this pull request
Sep 4, 2019
Bug fix for SCM time index for IOP forcing data This bug fix effects single column model (SCM) cases when the temporal resolution of the forcing is different than that of E3SM. Here the index "i" in the iteration loop to find the next available forcing is redundant and can result in forcing being read in with a time step lag. Also cleaned up the print statements to the E3SM logs to make them more verbose and to print out the correct values. All E3SM developer tests pass, except SMS_R_Ld5.ne4_ne4.FSCM5A97, which is an expected fail [BFB] except for the SCM test.
|
Merged to master. Requests submitted to bless diffs for the SCM tests on sandiatoss3 and melvin. |
rljacob
pushed a commit
that referenced
this pull request
Apr 21, 2021
…9-06-25 Jgfouca/branch for acme split 2019 06 25 Changes: * Add UA and COARE ocean surface flux schemes (#2972) Test suite: scripts_regression_tests Test baseline: Test namelist changes: Test status: bit for bit Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?: Code review: @jedwards4b
rljacob
pushed a commit
that referenced
this pull request
May 6, 2021
…9-06-25 Jgfouca/branch for acme split 2019 06 25 Changes: * Add UA and COARE ocean surface flux schemes (#2972) Test suite: scripts_regression_tests Test baseline: Test namelist changes: Test status: bit for bit Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?: Code review: @jedwards4b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug fix effects single column model (SCM) cases when the temporal resolution of the forcing is different than that of E3SM. Here the index "i" in the iteration loop to find the next available forcing is redundant and can result in forcing being read in with a time step lag.
Also cleaned up the print statements to the E3SM logs to make them more verbose and to print out the correct values.
All E3SM developer tests pass, except SMS_R_Ld5.ne4_ne4.FSCM5A97, which is an expected fail