Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing files to preqx_kokkos build #3185

Merged
merged 3 commits into from
Nov 4, 2019
Merged

Adds missing files to preqx_kokkos build #3185

merged 3 commits into from
Nov 4, 2019

Conversation

oksanaguba
Copy link
Contributor

@oksanaguba oksanaguba commented Sep 16, 2019 •
edited
Loading

Adds missing files to preqx_kokkos standalone build. Won't affect nightlies, CAM run with hommexx core builds.

[bfb]

@rljacob rljacob added the HOMME label Sep 19, 2019
@jgfouca
Copy link
Member

jgfouca commented Sep 20, 2019

Is this a work in progress?

@oksanaguba
Copy link
Contributor Author

Not really, it is good except I haven't decided what to do about 3 summit cmake files. I will make up my mind soon, thanks.

@oksanaguba
Copy link
Contributor Author

@rljacob I found this one, too, which I am going to sort now. thanks.

@oksanaguba
Copy link
Contributor Author

oksanaguba commented Nov 1, 2019 •
edited
Loading

@jgfouca @rljacob is it ok if I reassign it to myself and push it to next and master today? it only affects preqx_kokkos standalone build, which is not used in nightlies (yet).

@jgfouca
Copy link
Member

jgfouca commented Nov 1, 2019

@oksanaguba , yes that's fine.

@oksanaguba oksanaguba assigned oksanaguba and unassigned jgfouca Nov 1, 2019
@oksanaguba oksanaguba added the HOMME standalone issues with the standalone HOMME code that dont impact E3SM label Nov 1, 2019
@oksanaguba
Copy link
Contributor Author

Will merge when repos are open.

@oksanaguba oksanaguba added the BFB PR leaves answers BFB label Nov 4, 2019
oksanaguba added a commit that referenced this pull request Nov 4, 2019
@oksanaguba
Merge branch 'origin/oksanaguba/homme/summit-fixes-sept2019' into nex…
8425e3d 
…t (PR #3185)

Adds missing files to preqx_kokkos standalone build.
Won't affect nightlies, CAM run with hommexx core builds.

[bfb]
oksanaguba added a commit that referenced this pull request Nov 4, 2019
@oksanaguba
Merge branch 'origin/oksanaguba/homme/summit-fixes-sept2019' into mas…
7b17cf8 
…ter (PR #3185)

Adds missing files to preqx_kokkos standalone build.
Won't affect nightlies, CAM run with hommexx core builds.

[bfb]
@oksanaguba oksanaguba merged commit 0e505a9 into master Nov 4, 2019
@oksanaguba
Copy link
Contributor Author

Merged to next and master.

@oksanaguba oksanaguba deleted the oksanaguba/homme/summit-fixes-sept2019 branch November 5, 2019 19:29
@oksanaguba oksanaguba restored the oksanaguba/homme/summit-fixes-sept2019 branch December 3, 2019 20:40
@oksanaguba oksanaguba deleted the oksanaguba/homme/summit-fixes-sept2019 branch October 18, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oksanaguba oksanaguba

Labels
BFB PR leaves answers BFB HOMME standalone issues with the standalone HOMME code that dont impact E3SM HOMME
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oksanaguba @jgfouca @rljacob