Fix no_batch determination in case_submit

[jgfouca]

Fixes #3166

[BFB]

[jgfouca]

@jedwards4b , will you take a quick look at this? This bug was introduced into E3SM in a recent CIME update. My hunch is that no_batch should always be true if env_batch.get_batch_system_type() == "none".

[jedwards4b]

There is also a bug a couple of lines down:
replace

if batch_system != "none" and env_batch_has_changed or external_workflow:

with

if batch_system != "none" and (env_batch_has_changed or external_workflow):

[jgfouca]

@jedwards4b , I think you are talking about this line:

if batch_system != "none" and env_batch_has_changed and not external_workflow:

I believe this line is correct.

[jedwards4b]

hmm - you have an and where I have an or - is that logically the same as adding ()? I'll need to think about it.

[jgfouca]

@jedwards4b , we can resolve in the next split.