Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPAS Standalone: Fix check for LAPACK libraries #4972

Merged
merged 1 commit into from
Jun 3, 2022
Merged

MPAS Standalone: Fix check for LAPACK libraries #4972

merged 1 commit into from
Jun 3, 2022

Conversation

xylar
Copy link
Contributor

@xylar xylar commented May 20, 2022 •
edited by jonbob
Loading

Previously, there were error messages like:

ls: cannot access '/global/cfs/cdirs/e3sm/software/compass/cori-haswell/spack/spack_for_mache_1.4.1/var/spack/environments/dev_compass_1_1_0-alpha_4_gnu_mpt_netlib_lapack_petsc/.spack-env/view/liblapack.*': No such file or directory

even though this just means that the correct directory for LAPACK had not yet been found.

[BFB]

@xylar
Fix check for LAPACK libraries
dc680ed 
Previously, there were error messages like:
```
ls: cannot access '/global/cfs/cdirs/e3sm/software/compass/cori-haswell/spack/spack_for_mache_1.4.1/var/spack/environments/dev_compass_1_1_0-alpha_4_gnu_mpt_netlib_lapack_petsc/.spack-env/view/liblapack.*': No such file or directory
```
even though this just means that the correct directory for LAPACK
had not yet been found.
@xylar xylar requested a review from mark-petersen May 20, 2022 23:54
@xylar xylar added the BFB PR leaves answers BFB label May 20, 2022
@xylar
Copy link
Contributor Author

xylar commented May 20, 2022

Testing

I built standalone MPAS-Ocean with this fix. Previously, I was seeing the error message shown above. With this branch, the error message goes away.

@xylar
Copy link
Contributor Author

xylar commented May 20, 2022

@mark-petersen, I believe this was introduced in #4214, as I don't see any evidence of this ls style syntax in MPAS-Dev/MPAS-Model. It seems like using wildcard instead of shell ls is the solution, as in the rest of the Makefile.

Could you take a look and let me know if you agree?

mark-petersen
mark-petersen approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar thanks for fixing this. I don't remember putting in the shell ls myself, but the wildcard is better. I test compiled this with gnu and intel, each with debug and optimized, and all compiled fine.

@jonbob jonbob removed the bug fix PR label Jun 2, 2022
jonbob added a commit that referenced this pull request Jun 2, 2022
@jonbob
Merge branch 'xylar/mpas-framework/fix-lapack-check' into next (PR #4972
d90b2da 
)

MPAS Standalone: Fix check for LAPACK libraries

Fixes an issue with standalone MPAS builds which resulted in error
messages about a missing library even though this just means that the
correct directory for LAPACK had not yet been found. Does not impact
the E3SM build system.

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Jun 2, 2022

passes sanity testing, merged to next

@jonbob jonbob merged commit 681717d into E3SM-Project:master Jun 3, 2022
@jonbob
Copy link
Contributor

jonbob commented Jun 3, 2022

merged to master

@xylar xylar deleted the mpas-framework/fix-lapack-check branch June 3, 2022 17:12
@xylar
Copy link
Contributor Author

xylar commented Jun 3, 2022

Thanks as always, @jonbob!

@xylar xylar mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-petersen mark-petersen mark-petersen approved these changes

Assignees

@jonbob jonbob

Labels
BFB PR leaves answers BFB mpas-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xylar @jonbob @mark-petersen