change the grid to r05_r05 for lnd_rof_two_way test #6388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rljacob
added
MOSART
tanzeli1982
approved these changes
May 2, 2024
|
Since this has one review and the discussion on the other PR seemed to reach an agreement, I'll go ahead and merge this PR and the other one today |
peterdschwartz
added a commit
that referenced
this pull request
May 9, 2024
) ERS.f09_f09.IELM.elm-lnd_rof_2way in the test suits results in negative channel water storage in MOSART. This was raised in #6313. The reason is that f09_f09 uses different spatial resolutions in ELM and MOSART. This is problematic for land river two-way coupling, which requires the same grid in ELM and MOSART. This PR changed f09_f09 to r05_r05 for the land river two-way test, and there is no negative main channel storage. [BFB]
|
merged to next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERS.f09_f09.IELM.elm-lnd_rof_2way in the test suits results in negative channel water storage in MOSART.
This was raised in #6313.
The reason is that f09_f09 uses different spatial resolutions in ELM and MOSART.
This is problematic for land river two-way coupling, which requires the same grid in ELM and MOSART.
This PR changed f09_f09 to r05_r05 for the land river two-way test, and there is no negative main channel storage.
[BFB]