Revert PR #6313 aborting run on negative channel storage #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bishtgautam
approved these changes
Sep 17, 2024
rljacob
reviewed
Sep 17, 2024
| @@ -682,8 +682,8 @@ subroutine Euler | |||
|
|
|||
| ! check for negative channel storage | |||
| if (negchan < -1.e-10) then | |||
| write(iulog,*) 'Error: Negative channel storage found! ',negchan | |||
| call shr_sys_abort('mosart: negative channel storage') | |||
| write(iulog,*) 'Warning: Negative channel storage found! ',negchan | |||
There was a problem hiding this comment.
are you sure you want to print a warning? Was that the old behavior?
There was a problem hiding this comment.
Another PR, #6568, resolved this aborting issue with a cleaner solution. Should we discuss and then discuss how to proceed with these two options?
There was a problem hiding this comment.
This one will have to go in for the 3.0.1 tag. Then your other fix can be used for 3.1.0.
|
Should I merge this today? |
wlin7
added a commit
that referenced
this pull request
Sep 17, 2024
…#6623) Revert PR #6313 aborting run on negative channel storage The enforced abort whenever MOSART has negative channel storage may prevent v3.LR simulations from finishing, if the code base that includes to ensure new v3.LR simulations that need to use the latest commits to master are free from this issue. Fixes #6622. [BFB]
|
I just merged it to next, @peterdschwartz , after seeing Rob's message on slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enforced abort whenever MOSART has negative channel storage
may prevent v3.LR simulations from finishing, if the code base that includes
#6313 is used. This PR is to revert #6313 until v3.0.1 tag is created,
to ensure new v3.LR simulations that need to use the latest commits to master
are free from this issue.
Fixes #6622.
[BFB]
Issue #6302 is expected to reemerge.