Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for MALI to create separate logs from each processor #6694

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented Oct 17, 2024

Adds a new variable config_create_all_logs_in_e3sm to MALI that allows users to choose to get a separate log file from each processor

[NML] for configurations with MALI
[BFB]

@jonbob jonbob added mpas-albany-landice BFB PR leaves answers BFB labels Oct 17, 2024
@jonbob jonbob self-assigned this Oct 17, 2024
@jonbob
Copy link
Contributor Author

jonbob commented Oct 17, 2024

@xylar and @mark-petersen -- I've added you to this PR mostly to help decide if the other MPAS components might benefit from a similar option

Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6694/
on branch gh-pages at 2024-10-17 18:20 UTC

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving based on an inspection of the code. This looks like it would be a good capability for us to port to MPAS-Ocean and -Seaice, too, as we have discussed.

@rljacob
Copy link
Member

rljacob commented Oct 17, 2024

I already see a log.albany.XXXX.out file for every processor when I ran a test case. So what is this PR doing?

@xylar
Copy link
Contributor

xylar commented Oct 17, 2024

@rljacob, those are from Albany, not MALI. Not having one Albany log per core would be a different issue, presumably for a different PR to Albany itself.

Copy link
Contributor

@matthewhoffman matthewhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonbob , this looks great. @stephenprice has tested it and confirms that it generates MALI log files for each processor, which has been invaluable for debugging an error occurring on a processor that isn't the head proc.

Given @xylar's response, do you want to add the other MPAS components to this same PR?

@@ -1087,6 +1087,14 @@ Valid values: .true. or .false.
Default: Defined in namelist_defaults.xml
</entry>

<entry id="config_create_all_logs_in_e3sm" type="logical"
category="io" group="io">
Logical flag determining if log files will be created for each processor in an E3SM configuration. If .true., the model initializes and writes to one files per processor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Logical flag determining if log files will be created for each processor in an E3SM configuration. If .true., the model initializes and writes to one files per processor.
Logical flag determining if log files will be created for each processor in an E3SM configuration. If .true., the model initializes and writes to one file per processor.

Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewhoffman this looks useful, and easy to control with a simple flag. Thanks for pointing it out.

jonbob added a commit that referenced this pull request Oct 30, 2024
Add ability for MALI to create separate logs from each processor

Adds a new variable config_create_all_logs_in_e3sm to MALI that allows
users to choose to get a separate log file from each processor

[BFB]
@jonbob
Copy link
Contributor Author

jonbob commented Oct 30, 2024

passes e3sm_landice_developer on chrysalis with gnu compiler, with the exception of

merged to next

@jonbob jonbob added the NML label Oct 31, 2024
@jonbob jonbob merged commit 0291efc into master Oct 31, 2024
5 checks passed
@jonbob jonbob deleted the jonbob/mali/create-all-logs branch October 31, 2024 16:39
@jonbob
Copy link
Contributor Author

jonbob commented Oct 31, 2024

merged to master and expected NML DIFFs blessed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants