-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for MALI to create separate logs from each processor #6694
Conversation
@xylar and @mark-petersen -- I've added you to this PR mostly to help decide if the other MPAS components might benefit from a similar option |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving based on an inspection of the code. This looks like it would be a good capability for us to port to MPAS-Ocean and -Seaice, too, as we have discussed.
I already see a log.albany.XXXX.out file for every processor when I ran a test case. So what is this PR doing? |
@rljacob, those are from Albany, not MALI. Not having one Albany log per core would be a different issue, presumably for a different PR to Albany itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonbob , this looks great. @stephenprice has tested it and confirms that it generates MALI log files for each processor, which has been invaluable for debugging an error occurring on a processor that isn't the head proc.
Given @xylar's response, do you want to add the other MPAS components to this same PR?
@@ -1087,6 +1087,14 @@ Valid values: .true. or .false. | |||
Default: Defined in namelist_defaults.xml | |||
</entry> | |||
|
|||
<entry id="config_create_all_logs_in_e3sm" type="logical" | |||
category="io" group="io"> | |||
Logical flag determining if log files will be created for each processor in an E3SM configuration. If .true., the model initializes and writes to one files per processor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logical flag determining if log files will be created for each processor in an E3SM configuration. If .true., the model initializes and writes to one files per processor. | |
Logical flag determining if log files will be created for each processor in an E3SM configuration. If .true., the model initializes and writes to one file per processor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewhoffman this looks useful, and easy to control with a simple flag. Thanks for pointing it out.
Add ability for MALI to create separate logs from each processor Adds a new variable config_create_all_logs_in_e3sm to MALI that allows users to choose to get a separate log file from each processor [BFB]
passes e3sm_landice_developer on chrysalis with gnu compiler, with the exception of
merged to next |
merged to master and expected NML DIFFs blessed |
Adds a new variable config_create_all_logs_in_e3sm to MALI that allows users to choose to get a separate log file from each processor
[NML] for configurations with MALI
[BFB]