Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new picard nonconvergence messages. #6

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Add new picard nonconvergence messages. #6

merged 1 commit into from
Sep 8, 2022

Conversation

dabail10
Copy link

@dabail10 dabail10 commented Sep 1, 2022

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Add additional information to the Picard nonconvergence subroutine.
  • Developer(s):
    dabail10 (D. Bailey)
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Compiles and runs in a single case.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    @eclare108213 @apcraig @akturner

Copy link
Collaborator

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you create a test case that fails to converge, to see the output? I had one earlier today... :)

@dabail10
Copy link
Author

dabail10 commented Sep 2, 2022

I did Elizabeth's test that failed and here is the new output:

picard convergence failed!

Surface: Tsf0, Tsf
0 -30.394500280862609 NaN

Snow: zTsn0(k), zTsn(k), zqsn0(k), ks(k), Sswabs(k)
1 -29.126564365877528 NaN -130462379.70299758 0.29999999999999999 N
aN

Ice: zTin0(k), zTin(k), zSin0(k), zSin(k), phi(k), zqin0(k), km(k), Iswabs(k), dSdt(k)
1 -27.564099780583771 NaN 12.702023524591246 9.9999999999997868E-003 4.9355390398570134E-0
02 -347653615.15351915 2.2130111244225201 NaN -0.0000000000000000
2 -22.154685027636670 NaN 11.455632525059242 9.9999999999997868E-003 5.0851638610074870E-002 -336188297.34063733 2.2103739869497430 NaN -1.4620410644527047E-007
3 -16.977709524760932 NaN 10.602935452517320 9.9999999999997868E-003 5.5262910678289388E-002 -324388027.44904798 2.2025991199295150 NaN -7.6949972318895542E-007
4 -12.071153928062893 NaN 10.215296112150895 9.9999999999997868E-003 6.4890647660878167E-002 -311592422.61542195 2.1856302334977022 NaN -1.7863746425062213E-006
5 -7.4629409422930024 NaN 10.377177159746095 9.9999999999997868E-003 8.5620377519279992E-002 -295998101.90322077 2.1490940846222690 NaN -3.2899607527392630E-006
6 -3.2591935367483966 NaN 11.501572730338641 9.9999999999997868E-003 0.20246276289361334 -252143615.80676761 1.9431593804000062 NaN -6.6003347617093794E-006
7 -1.4629218193533744 NaN 17.549948536680578 1.0000000000001563E-002 0.66671146031413986 -107241530.20791294 1.1249210511963286 NaN -1.2371149416801811E-005

Ice boundary: q(k)
0 0.0000000000000000
1 0.0000000000000000
2 0.0000000000000000
3 0.0000000000000000
4 0.0000000000000000
5 0.0000000000000000
6 3.6625816729655862E-009
7 0.0000000000000000

dt: 3600.0000000000000
hilyr: 0.26689513353862360
hslyr: 2.7771809939773200E-004
Tbot: -1.9045826499242646
fswint: NaN
fswsfc: NaN
rhoa: 1.2749999999999999
flw: 163.99059139784944
potT: 241.74623655913976
Qa: 1.8239307762786688E-004
Note: The following floating-point exceptions are signalling: IEEE_INVALID_FLAG
shcoef: 11.592313874064743
lhcoef: 29873.673214496353
qpond: 0.0000000000000000
qocn: -8242401.3874324420
Spond: 0.0000000000000000
sss: 34.000000000000000
w: 0.0000000000000000
flwoutn: NaN
fsensn: NaN
flatn: NaN
fsurfn: NaN
fcondtop: NaN
fcondbot: NaN
fadvheat: NaN


(picard_solver) picard_solver: Picard solver non-convergence

@eclare108213 eclare108213 merged commit fd1942c into E3SM-Project:main Sep 8, 2022
eclare108213 added a commit that referenced this pull request Sep 30, 2022
Update ssp data for dEdd_snicar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants