Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify simple_image_name #358

Closed
Tracked by #553
forsyth2 opened this issue Nov 17, 2022 · 0 comments · Fixed by #628
Closed
Tracked by #553

Clarify simple_image_name #358

forsyth2 opened this issue Nov 17, 2022 · 0 comments · Fixed by #628
Assignees
@forsyth2
Labels
Testing Files in `tests` modified

Comments

@forsyth2
Copy link
Collaborator

simple_image_name in https://github.com/E3SM-Project/zppy/blob/main/tests/integration/utils.py needs to be fixed for proper testing.

Currently:

simple_image_name = image_name.split("/")[-1].split(".")[0]

For example both of

e3sm_diags/atm_monthly_180x360_aave/model_vs_obs_1850-1853/lat_lon/CERES-EBAF-surface-v4.1/ceres_ebaf_surface_v4.1-ALBEDO_SRF-SON-global.png
e3sm_diags/atm_monthly_180x360_aave/model_vs_obs_1850-1851/lat_lon/CERES-EBAF-surface-v4.1/ceres_ebaf_surface_v4.1-ALBEDO_SRF-DJF-global.png

would get mapped to 'ceres_ebaf_surface_v4' in the image_check_failures directory, even though they have different years (1850-1853 -- 1850-1851) and different months (SON -- DJF)
@forsyth2 forsyth2 added the Testing Files in `tests` modified label Nov 17, 2022
@forsyth2 forsyth2 self-assigned this Nov 17, 2022
@forsyth2 forsyth2 mentioned this issue Feb 21, 2024
Open
14 tasks
This was referenced Oct 4, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@forsyth2 forsyth2

Labels
Testing Files in `tests` modified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve input validation and testing E3SM-Project/zppy
1 participant
@forsyth2