Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten arguments for ncclimo #97

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Conversation

forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Jul 14, 2021

Shorten arguments for ncclimo calls related to diurnal cycle. Resolves #96.

@forsyth2 forsyth2 added the semver: bug Bug fix (will increment patch version) label Jul 14, 2021
@forsyth2 forsyth2 self-assigned this Jul 14, 2021
@forsyth2
Copy link
Collaborator Author

@golaz I'm not sure I did the fix correctly. I'm getting the following errors:

In climo_atm_monthly_diurnal output:

ncks: ERROR file time,1 not found. It does not exist on the local filesystem, nor does it match remote filename patterns (e.g.\
, http://foo or foo.bar.edu:file).
ncks: HINT file-not-found errors usually arise from filename typos, incorrect paths, missing files, or capricious gods. Please\
 verify spelling and location of requested file. If the file resides on a High Performance Storage System (HPSS) accessible vi\
a the 'hsi' command, then add the --hpss option and re-try command.
ncclimo: ERROR Inferred value of tpd= is not a positive integer. User requested high-frequency climatology or splitter operati\
ons without specifying the number of timesteps per day (tpd) in the input files, so ncclimo tried to infer tpd from the first \
input file. This operation resulted in a nonsense value. This is not surprising since a number of assumptions must hold true f\
or the inferral to work correctly.
HINT: Explicitly specify the number of timesteps-per-day in every input file with the --tpd option.

In all ts_* output:

ncclimo: ERROR Specify input file(s) with -i $drc_in or with positional argument(s) or with stdin
ncclimo: HINT Pipe input file list to stdin with, e.g., 'ls *.nc | ncclimo'

@golaz
Copy link
Collaborator

golaz commented Jul 14, 2021

Looks like it's not working. Maybe rerun with the debug option and check the content of input.txt.

@forsyth2
Copy link
Collaborator Author

@golaz I added a second commit that seems to work when I run zppy with it. Let me know if this change looks good and I'll merge.

@golaz
Copy link
Collaborator

golaz commented Jul 15, 2021

@forsyth2 : interesting how the change from < input.txt to cat input.txt | solves your problem. Some OS subtleties that I don't understand (and don't need to).

You may want to make additional minor changes: remove the trailing \ on lines preceding the deleted last line. It probably works as is, but relies on the presence of white lines which could break easily in the future.

@golaz
Copy link
Collaborator

golaz commented Jul 15, 2021

Note: this might be difficult to do for ts.bash due to the if statements. Maybe just leave it as is.

@forsyth2 forsyth2 merged commit 2d6664a into E3SM-Project:main Jul 15, 2021
@forsyth2 forsyth2 deleted the shorten-args branch July 15, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: bug Bug fix (will increment patch version)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command line arguments too long
2 participants