Fixes #3796 upgrade rails_admin gem #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Morrism1 - thank you for contributing! Unfortunately, it looks like something went wrong - you should only need to change a handful of files, but this is reporting 500+. Please fix that and re-push |
I did mess up the changes due to the Rspec actions was failing but locally was working, but I reverted the changes now. I think it is all good. 🤦🏽♂️ |
|
@Morrism1 Yes, we've tracked down the issue to a configuration problem with Docker, but otherwise I'm running the tests myself locally to verify things are good. |
rlgreen91
approved these changes
Oct 13, 2020
mockdeep
added a commit
that referenced
this pull request
Jan 18, 2021
**What** * Update the CI configuration for Rubocop to install the same version that is specified in `Gemfile.lock`. I think it might be better to run `bundle` instead of installing `rubocop` directly, but it will be good to set up caching to reduce performance overhead. * Downcase `PWD`. I'm guessing these files were developed on a file system that is not case sensitive. Linux, on the other hand, is. * Introduce `config/manifest.js`. Sprockets throws an error when trying to boot the server. It now requires this file to exist, I believe as of version 4.0. I'm guessing this issue started in #3797.
mockdeep
added a commit
that referenced
this pull request
Jan 18, 2021
**What** * Update the CI configuration for Rubocop to install the same version that is specified in `Gemfile.lock`. I think it might be better to run `bundle` instead of installing `rubocop` directly, but it will be good to set up caching to reduce performance overhead. * Downcase `PWD`. I'm guessing these files were developed on a file system that is not case sensitive. Linux, on the other hand, is. * Introduce `config/manifest.js`. Sprockets throws an error when trying to boot the server. It now requires this file to exist, I believe as of version 4.0. I'm guessing this issue started in #3797.
mockdeep
added a commit
that referenced
this pull request
Jan 18, 2021
**What** * Update the CI configuration for Rubocop to install the same version that is specified in `Gemfile.lock`. I think it might be better to run `bundle` instead of installing `rubocop` directly, but it will be good to set up caching to reduce performance overhead. * Downcase `PWD`. I'm guessing these files were developed on a file system that is not case sensitive. Linux, on the other hand, is. * Introduce `config/manifest.js`. Sprockets throws an error when trying to boot the server. It now requires this file to exist, I believe as of version 4.0. I'm guessing this issue started in #3797. * Disable Rollbar in dev/test mode.
mockdeep
added a commit
that referenced
this pull request
Jan 18, 2021
**What** * Update the CI configuration for Rubocop to install the same version that is specified in `Gemfile.lock`. I think it might be better to run `bundle` instead of installing `rubocop` directly, but it will be good to set up caching to reduce performance overhead. * Downcase `PWD`. I'm guessing these files were developed on a file system that is not case sensitive. Linux, on the other hand, is. * Introduce `config/manifest.js`. Sprockets throws an error when trying to boot the server. It now requires this file to exist, I believe as of version 4.0. I'm guessing this issue started in #3797. * Disable Rollbar in dev/test mode.
mockdeep
added a commit
that referenced
this pull request
Jan 18, 2021
**What** * Update the CI configuration for Rubocop to install the same version that is specified in `Gemfile.lock`. I think it might be better to run `bundle` instead of installing `rubocop` directly, but it will be good to set up caching to reduce performance overhead. * Downcase `PWD`. I'm guessing these files were developed on a file system that is not case sensitive. Linux, on the other hand, is. * Introduce `config/manifest.js`. Sprockets throws an error when trying to boot the server. It now requires this file to exist, I believe as of version 4.0. I'm guessing this issue started in #3797. * Disable Rollbar in dev/test mode. * Update CodeClimate in `Makefile` to use `shell` keyword. `pwd` was returning nothing, so it wasn't able to properly find the config file.
mockdeep
added a commit
that referenced
this pull request
Jan 18, 2021
**What** * Update the CI configuration for Rubocop to install the same version that is specified in `Gemfile.lock`. I think it might be better to run `bundle` instead of installing `rubocop` directly, but it will be good to set up caching to reduce performance overhead. * Downcase `PWD`. I'm guessing these files were developed on a file system that is not case sensitive. Linux, on the other hand, is. * Introduce `config/manifest.js`. Sprockets throws an error when trying to boot the server. It now requires this file to exist, I believe as of version 4.0. I'm guessing this issue started in #3797. * Disable Rollbar in dev/test mode. * Update CodeClimate in `Makefile` to use [the `shell` keyword][shell]. `pwd` was returning nothing, so it wasn't able to properly find the config file. [shell]: https://stackoverflow.com/a/18137056/372479
mockdeep
added a commit
that referenced
this pull request
Jan 18, 2021
**What** * Update the CI configuration for Rubocop to install the same version that is specified in `Gemfile.lock`. I think it might be better to run `bundle` instead of installing `rubocop` directly, but it will be good to set up caching to reduce performance overhead. * Downcase `PWD`. I'm guessing these files were developed on a file system that is not case sensitive. Linux, on the other hand, is. * Introduce `config/manifest.js`. Sprockets throws an error when trying to boot the server. It now requires this file to exist, I believe as of version 4.0. I'm guessing this issue started in #3797. * Disable Rollbar in dev/test mode. * Update CodeClimate in `Makefile` to use [the `shell` keyword][shell]. `pwd` was returning nothing, so it wasn't able to properly find the config file. [shell]: https://stackoverflow.com/a/18137056/372479
mockdeep
added a commit
that referenced
this pull request
Jan 18, 2021
**What** * Update the CI configuration for Rubocop to install the same version that is specified in `Gemfile.lock`. I think it might be better to run `bundle` instead of installing `rubocop` directly, but it will be good to set up caching to reduce performance overhead. * Downcase `PWD`. I'm guessing these files were developed on a file system that is not case sensitive. Linux, on the other hand, is. * Introduce `config/manifest.js`. Sprockets throws an error when trying to boot the server. It now requires this file to exist, I believe as of version 4.0. I'm guessing this issue started in #3797. * Disable Rollbar in dev/test mode. * Update CodeClimate in `Makefile` to use [the `shell` keyword][shell]. `pwd` was returning nothing, so it wasn't able to properly find the config file. * Disable concurrent exports for Sprockets. It has a tendency to [cause segfaults][seg] in Ruby, making builds (and deploys) super flaky. [shell]: https://stackoverflow.com/a/18137056/372479 [seg]: sass/sassc-ruby#207
mockdeep
added a commit
that referenced
this pull request
Jan 18, 2021
**What** * Introduce `app/assets/config/manifest.js`. Sprockets was [recently upgraded][upgrade] to version 4, but [it now requires this file][file] to exist in order to determine which files to compile. * Disable concurrent exports for Sprockets. It has a tendency to [cause segfaults][segfault] in Ruby, making builds (and deploys) super flaky. I've already seen it fail a few times working on getting the build passing. [upgrade]: #3797 [file]: https://github.com/rails/sprockets/blob/master/UPGRADING.md#manifestjs [segfault]: sass/sassc-ruby#207
mockdeep
added a commit
that referenced
this pull request
Jan 18, 2021
**What** * Introduce `app/assets/config/manifest.js`. Sprockets was [recently upgraded][upgrade] to version 4, but [it now requires this file][file] to exist in order to determine which files to compile. * Disable concurrent exports for Sprockets. It has a tendency to [cause segfaults][segfault] in Ruby, making builds (and deploys) super flaky. I've already seen it fail a few times working on getting the build passing. [upgrade]: #3797 [file]: https://github.com/rails/sprockets/blob/master/UPGRADING.md#manifestjs [segfault]: sass/sassc-ruby#207
mockdeep
added a commit
that referenced
this pull request
Jan 18, 2021
**What** * Update the CI configuration for Rubocop to install the same version that is specified in `Gemfile.lock`. I think it might be better to run `bundle` instead of installing `rubocop` directly, but it will be good to set up caching to reduce performance overhead. * Downcase `PWD`. I'm guessing these files were developed on a file system that is not case sensitive. Linux, on the other hand, is. * Introduce `config/manifest.js`. Sprockets throws an error when trying to boot the server. It now requires this file to exist, I believe as of version 4.0. I'm guessing this issue started in #3797. * Disable Rollbar in dev/test mode. * Update CodeClimate in `Makefile` to use [the `shell` keyword][shell]. `pwd` was returning nothing, so it wasn't able to properly find the config file. * Disable concurrent exports for Sprockets. It has a tendency to [cause segfaults][seg] in Ruby, making builds (and deploys) super flaky. [shell]: https://stackoverflow.com/a/18137056/372479 [seg]: sass/sassc-ruby#207
mockdeep
added a commit
that referenced
this pull request
Jan 19, 2021
**What** * Update the CI configuration for Rubocop to install the same version that is specified in `Gemfile.lock`. I think it might be better to run `bundle` instead of installing `rubocop` directly, but it will be good to set up caching to reduce performance overhead. * Downcase `PWD`. I'm guessing these files were developed on a file system that is not case sensitive. Linux, on the other hand, is. * Introduce `config/manifest.js`. Sprockets throws an error when trying to boot the server. It now requires this file to exist, I believe as of version 4.0. I'm guessing this issue started in #3797. * Disable Rollbar in dev/test mode. * Update CodeClimate in `Makefile` to use [the `shell` keyword][shell]. `pwd` was returning nothing, so it wasn't able to properly find the config file. * Disable concurrent exports for Sprockets. It has a tendency to [cause segfaults][seg] in Ruby, making builds (and deploys) super flaky. [shell]: https://stackoverflow.com/a/18137056/372479 [seg]: sass/sassc-ruby#207
mockdeep
added a commit
that referenced
this pull request
Jan 19, 2021
**What** * Introduce `app/assets/config/manifest.js`. Sprockets was [recently upgraded][upgrade] to version 4, but [it now requires this file][file] to exist in order to determine which files to compile. * Disable concurrent exports for Sprockets. It has a tendency to [cause segfaults][segfault] in Ruby, making builds (and deploys) super flaky. I've already seen it fail a few times working on getting the build passing. [upgrade]: #3797 [file]: https://github.com/rails/sprockets/blob/master/UPGRADING.md#manifestjs [segfault]: sass/sassc-ruby#207
rlgreen91
pushed a commit
that referenced
this pull request
Jan 30, 2021
**What** * Introduce `app/assets/config/manifest.js`. Sprockets was [recently upgraded][upgrade] to version 4, but [it now requires this file][file] to exist in order to determine which files to compile. * Disable concurrent exports for Sprockets. It has a tendency to [cause segfaults][segfault] in Ruby, making builds (and deploys) super flaky. I've already seen it fail a few times working on getting the build passing. [upgrade]: #3797 [file]: https://github.com/rails/sprockets/blob/master/UPGRADING.md#manifestjs [segfault]: sass/sassc-ruby#207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In your PR did you:
Upgraded Rails_admin gem to ~> 2.0
Fixes Upgrade rails_admin gem #3796 upgrade rails_admin gem
Include a description of the changes?
Mention the issue the PR addresses?
Isolate any changes to gems (meaning that any new, updated, or removed gems and resulting code changes should be in their own PR)?
- Add and/or update specs for your code?