Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in rgb2lab transform #50

Open
Vlad-C-Crisan opened this issue Aug 11, 2023 · 2 comments · May be fixed by #51
Open

Typo in rgb2lab transform #50

Vlad-C-Crisan opened this issue Aug 11, 2023 · 2 comments · May be fixed by #51
Assignees
@andreped
Labels
bug Something isn't working

Comments

@Vlad-C-Crisan
Copy link

Vlad-C-Crisan commented Aug 11, 2023 •
edited
Loading

Describe the bug
In THIS LINE from rgb2lab implementation, the value 166 should be 116.

Expected behavior
The line should be changed to arr.masked_scatter_(not_mask, 7.787 * torch.masked_select(arr, not_mask) + 16 / 116) to match numpy implementation (e.g. THIS one from skimage)
@andreped andreped self-assigned this Aug 11, 2023
@andreped
Copy link
Collaborator

Good catch, @Vlad-C-Crisan! Surprising that this has not yet been observed.

I can make a PR.

@andreped andreped linked a pull request Aug 11, 2023 that will close this issue
Open
@andreped andreped added the bug Something isn't working label Aug 11, 2023
@andreped
Copy link
Collaborator

Made PR: #51

bertrandchauveau added a commit to bertrandchauveau/torchstain that referenced this issue Dec 1, 2024
@bertrandchauveau
Fixing typo (EIDOSLAB#50)
f4c9495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreped andreped

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed scaling value in torch rgb2lab andreped/torchstain
2 participants
@andreped @Vlad-C-Crisan