Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename specific_humidity #38

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

MayeulDestouches
Copy link
Collaborator

Description

This PR follows discussion in issue #36 about the ambiguous definition of specific humidity. Specific humidity is usually defined as the mixing ratio of the mass of water vapor to the mass of moist air, but moist air includes hydrometeors or not depending on who you are talking to.

This PR modifies rule 5 on mixing ratios:

  • The suffixes _wrt_moist_air and _wrt_total_mass are replaced by wrt_moist_air and _wrt_moist_air_and_condensed_water, which make it clearer that moist_air does not include condensed water in this standard.
  • specific_humidity is no longer proposed as an alias for water_vapor_mixing_ratio_wrt_moist_air, not to favor this definition over water_vapor_mixing_ratio_wrt_moist_air_and_condensed_water.

This PR also modifies the standard names specific_humidity and specific_humidity_at_2m into their explicit versions water_vapor_mixing_ratio_wrt_moist_air [ _and_condensed_water ] [ _at_2m ].

Issue addressed

Notes

I haven't replaced the 22 other names that are built on variants specific_humidity. If required, I can replace them by the current CCPP definition which is water_vapor_mixing_ratio_wrt_moist_air.

@mkavulich mkavulich requested review from grantfirl and nusbaume June 5, 2023 21:41
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK with me.

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good on NCAR's end, and since all reviewers have approved I'll also go ahead and merge it as well. Thanks for eliminating an extra source of name ambiguity!

@nusbaume nusbaume merged commit 7ad5f7c into ESCOMP:main Jun 13, 2023
@climbfuji
Copy link
Collaborator

@grantfirl I assume we need updates to ccpp-physics, scm, ufs-weather-model and neptune to reflect this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-universal definition of specific humidity
4 participants