Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c2l_scale_type not specified for many history fields #1

Open
billsacks opened this issue Dec 16, 2017 · 3 comments
Open

c2l_scale_type not specified for many history fields #1

billsacks opened this issue Dec 16, 2017 · 3 comments
Assignees
@adrifoster
Labels
bug something is working incorrectly priority: low Background task that doesn't need to be done right away. science Enhancement to or bug impacting science

Comments

@billsacks
Copy link
Member

Bill Sacks < sacks@ucar.edu > - 2011-08-22 13:49:04 -0600
Bugzilla Id: 1397
Bugzilla CC: oleson@ucar.edu, rfisher@ucar.edu, sacks@ucar.edu,

Many history fields do not have a c2l_scale_type parameter (in histFldsMod), but it seems they should. For example, there is a set of water flux variables, starting with QFLX_RAIN_GRND and ending with QFLX_DEW_SNOW, most of which do not have a c2l_scale_type. From talking with Keith Oleson, it seems that at least some and maybe all of these should have c2l_scale_type='urbanf', by analogy with similar fluxes that do have a c2l_scale_type specified.

From talking with Keith Oleson: it sounds like most fluxes should have c2l_scale_type='urbanf', but this isn't necessarily always true. So this will require more investigation to determine the appropriate scale type for each history field.

Most (all?) of the fields that do not have a c2l_scale_type are ones that were added after the urban model came in - for example, fields that were added when the CN code came in. So my guess is that whoever added these fields didn't realize that a c2l_scale_type was required.

After these fields are fixed, perhaps scale_type_c2l should be made a required argument to hist_addfld1d and hist_addfld2d to prevent this problem from arising again in the future.
@billsacks billsacks added this to the clm5 milestone Dec 16, 2017
@billsacks billsacks added the priority: low Background task that doesn't need to be done right away. label Dec 16, 2017
This was referenced Dec 16, 2017
Open
Closed
Closed
This was referenced Dec 16, 2017
Closed
Closed
Closed
Closed
Open
@billsacks billsacks mentioned this issue Jan 29, 2018
Open
swensosc referenced this issue in swensosc/ctsm Jun 11, 2018
@ekluzek
Merge pull request #1 from ckoven/radtemp
9800dd1 
added summary N litterfall flux variable
@billsacks billsacks removed this from the clm5 milestone Nov 7, 2018
billsacks referenced this issue in billsacks/ctsm Feb 22, 2019
@ekluzek
Merge pull request #1 from ckoven/radtemp
bf97230 
added summary N litterfall flux variable
billsacks pushed a commit that referenced this issue May 3, 2019
@slevis-lmwg
Merge pull request #1 from billsacks/hardcoded_params_out
1aa02ac 
Fix Fortran unit tests
@billsacks billsacks added tag: bug - impacts science bug something is working incorrectly and removed type: bug - impacts science labels May 24, 2019
@slevis-lmwg slevis-lmwg mentioned this issue Jul 10, 2019
Merged
billsacks referenced this issue in billsacks/ctsm Nov 1, 2019
@pengbinpeluo
Merge pull request #1 from billsacks/agsys
0a88295 
Organize agsys into 3 subdirectories
rgknox referenced this issue in rgknox/ctsm Mar 25, 2020
@JessicaNeedham
Merge pull request #1 from rgknox/JessicaNeedham-IO-sizeagemortality
e1128e9 
Added FATESSizeAge test protocol
billsacks referenced this issue in billsacks/ctsm Mar 27, 2020
@olyson
Merge pull request #1 from billsacks/svg_math
692c7fa 
Use svg rather than the default png for math images
@wwieder wwieder mentioned this issue Apr 3, 2020
Closed
billsacks referenced this issue in billsacks/ctsm Apr 7, 2020
@yanyanchengHydro
Merge pull request #1 from billsacks/bioenergy_billsacks_fixes
e3e668c 
Minor fixes for bioenergy branch
@dlawrenncar dlawrenncar mentioned this issue May 1, 2020
Closed
glemieux referenced this issue in glemieux/ctsm May 19, 2020
@rosiealice
Merge pull request #1 from glemieux/SP_next_api-add_tests
6e2a996 
Adding in test suite definition and pre-merge
ekluzek pushed a commit that referenced this issue May 28, 2020
@jtruesdal
Merge pull request #1 from ESCOMP/master
751a2ce 
update my ctsm fork to latest
glemieux pushed a commit that referenced this issue Jun 3, 2020
@rgknox
Merge pull request #1 from glemieux/fates_param_api11.1-external_cfg_…
27e2a6b 
…update

Updating externals_clm.cfg to point to the associated fates tag
glemieux pushed a commit that referenced this issue Jul 29, 2020
@ckoven
Merge pull request #1 from glemieux/ckoven-fates_landuse-model-day-fix
c2d497d 
Reinstate hlm_model_day fix from CTSM PR 820
billsacks added a commit that referenced this issue Sep 29, 2020
@billsacks
Merge pull request #1 from Ivanderkelen/dynlakes_master_notools
4f9dcdc 
Changes to review of dynlakes_master_notools

Response to review of Pull Request #1109:
including removal of lake_heat variable, update of surfrd_lakemask module and clean up of comments.
@ekluzek ekluzek mentioned this issue Feb 18, 2021
Closed
ekluzek pushed a commit that referenced this issue Aug 12, 2021
@negin513
Merge pull request #1 from jedwards4b/jedwards/neon_wrapper_cime
8d57f29 
add cime capabilities
MiCurry pushed a commit to MiCurry/CTSM that referenced this issue Sep 16, 2021
@dabail10
Merge pull request ESCOMP#1 from jedwards4b/jedwards/ice_atmo_fix
600587a 
fix iterative loop
billsacks pushed a commit that referenced this issue Dec 15, 2021
@fang-bowen
Merge pull request #1 from fang-bowen/dynamic_urban
eac83c1 
Created a new branch
billsacks pushed a commit that referenced this issue Dec 15, 2021
@fang-bowen
Revert "Merge pull request #1 from fang-bowen/dynamic_urban"
e729e7f 
This reverts commit eac83c1, reversing
changes made to 84e970f.
billsacks added a commit that referenced this issue Mar 16, 2022
@billsacks
Change LGRAIN tests to 1850
a9b4286 
Ideally we would do year-2000 tests to have more crop cover and thus
potentially be more useful tests. However, there are problems running a
year-2000 ciso test with crop. These problems exist even with an SMS
test on master:

I tried tests like
SMS_Ly1_P72x1.f10_f10_mg37.I2000Clm45BgcCrop.cheyenne_gnu.clm-ciso--clm-cropMonthOutput,
but both debug & non-debug, intel & gnu versions.

Debug tests fail like this (from SMS_D_Ly1_P72x1.f10_f10_mg37.I2000Clm45BgcCrop.cheyenne_gnu.clm-ciso--clm-cropMonthOutput):

30:Program received signal SIGFPE: Floating-point exception - erroneous arithmetic operation.
30:
30:Backtrace for this error:
13:
13:Program received signal SIGFPE: Floating-point exception - erroneous arithmetic operation.
13:
13:Backtrace for this error:
13:#0  0x2b9d1acc4aff in ???
30:#0  0x2b9d1acc4aff in ???
13:#1  0xf63fff in cisofluxcalc
13:     at /glade/work/sacks/ctsm_code/ctsm/src/biogeochem/CNCIsoFluxMod.F90:1555
30:#1  0xf63fff in cisofluxcalc
30:     at /glade/work/sacks/ctsm_code/ctsm/src/biogeochem/CNCIsoFluxMod.F90:1555
30:#2  0xf6b489 in __cncisofluxmod_MOD_cisoflux1
30:     at /glade/work/sacks/ctsm_code/ctsm/src/biogeochem/CNCIsoFluxMod.F90:153
13:#2  0xf6b489 in __cncisofluxmod_MOD_cisoflux1
13:     at /glade/work/sacks/ctsm_code/ctsm/src/biogeochem/CNCIsoFluxMod.F90:153
13:#3  0xe45657 in __cndrivermod_MOD_cndrivernoleaching
13:     at /glade/work/sacks/ctsm_code/ctsm/src/biogeochem/CNDriverMod.F90:559
30:#3  0xe45657 in __cndrivermod_MOD_cndrivernoleaching
30:     at /glade/work/sacks/ctsm_code/ctsm/src/biogeochem/CNDriverMod.F90:559

An intel test dies in the same place.

Non-debug versions die like this (both for gnu and intel):

30: set_curr_delta ERROR: found unexpected non-zero delta mid-year
30: Dribbler name: hrv_xsmrpool_to_atm_c_13
30: i, delta =            2                       NaN
30: Start of time step date (yr, mon, day, tod) =         2000           1          15       57600
30: This indicates that some non-zero flux was generated at a time step
30: other than the first time step of the year, which this dribbler was told not to expect.
30: If this non-zero mid-year delta is expected, then you can suppress this error
30: by setting allows_non_annual_delta to .true. when constructing this dribbler.
30:iam = 30: local  gridcell index = 2
30:iam = 30: global gridcell index = 103
30:iam = 30: gridcell longitude    =  285.0000000
30:iam = 30: gridcell latitude     =  -10.0000000
30: ENDRUN:
30: ERROR: set_curr_delta: found unexpected non-zero delta mid-year: ERROR in /glade/work/sacks/ctsm_code/ctsm/src/utils/AnnualFluxDr
ibbler.F90 at line 276

So there is some issue with year-2000 ciso tests with crop. This issue
exists on master, for clm45 and clm50 tests. (e.g., for clm50, I tried
SMS_D_Ly1_P72x1.f10_f10_mg37.I2000Clm50BgcCrop.cheyenne_gnu.clm-ciso--clm-cropMonthOutput.)
@wwieder wwieder mentioned this issue Apr 4, 2022
Open
9 tasks
estherbe3 pushed a commit to estherbe3/CTSM that referenced this issue Aug 5, 2022
@mvdebolskiy
Merge pull request ESCOMP#1 from kjetilaas/Exice_wTiles_HackAug2022
f76bae6 
Initial commit for excess ice snow redistribution
@adrifoster
Copy link
Collaborator

Is this still an issue? @billsacks

@billsacks
Copy link
Member Author

Good question. I'm not aware of it ever being addressed, but I can't say definitively that it's still an issue either.

@adrifoster
Copy link
Collaborator

As per discussion today the plan is to try to make a list of all the fields that need updating, make a google sheet for them, and crowd source which flag would go with it.

@adrifoster adrifoster self-assigned this Jul 13, 2023
samsrabin referenced this issue in samsrabin/CTSM Nov 1, 2023
@olyson
Merge pull request #1 from billsacks/zerothtstep
55184f4 
Fix unit tests for nstep starting at 1 instead of 0
@cathyxinchangli cathyxinchangli mentioned this issue Apr 18, 2024
Merged
4 tasks
samsrabin referenced this issue in samsrabin/CTSM Apr 19, 2024
@uturuncoglu
Merge pull request #1 from ESCOMP/master
447e1b6 
Minor typo fix in CDEPS cmake
AGonzalezNicolas referenced this issue in HPSCTerrSys/clm5_0 Jun 27, 2024
@ekluzek
Merge pull request #1 from ckoven/radtemp
386dffd 
added summary N litterfall flux variable
AGonzalezNicolas referenced this issue in HPSCTerrSys/clm5_0 Jun 27, 2024
@kvrigor
Functional CMake build scripts (PR #1)
5014d75 
Created CMake build scripts. Build succeeds on local dev machine (Ubuntu 20.04 LTS) and JUWELS (CentOS 8).
AGonzalezNicolas referenced this issue in HPSCTerrSys/clm5_0 Jun 27, 2024
@AGonzalezNicolas
Functional CMake build scripts (PR #1)
9eaa4d4
AGonzalezNicolas referenced this issue in HPSCTerrSys/clm5_0 Jul 5, 2024
@ekluzek
Merge pull request #1 from ckoven/radtemp
80fbcfd 
added summary N litterfall flux variable
adrifoster pushed a commit to adrifoster/CTSM that referenced this issue Jul 18, 2024
@samsrabin
Merge pull request ESCOMP#1 from glemieux/fates-landuse-v2-modechecks
1ffa406 
Update build namelist checks for valid landuse v2 mode combinations
@samsrabin samsrabin added science Enhancement to or bug impacting science and removed bug - impacts science labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrifoster adrifoster

Labels
bug something is working incorrectly priority: low Background task that doesn't need to be done right away. science Enhancement to or bug impacting science
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@billsacks @samsrabin @adrifoster