Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lake water to dynbal baselines #1140

Closed
billsacks opened this issue Sep 2, 2020 · 0 comments · Fixed by #1109
Closed

Add lake water to dynbal baselines #1140

billsacks opened this issue Sep 2, 2020 · 0 comments · Fixed by #1109
Assignees
Labels
enhancement new capability or improved behavior of existing capability

Comments

@billsacks
Copy link
Member

For the sake of dynamic lakes, we need to add lake water to dynbal baselines. This is done as part of #1109 , but I'm opening a separate issue to track this since it's leading to some subtle issues with respect to old initial conditions files: I think we need to put in place some code for the sake of backwards compatibility with these old initial conditions files: Any initial conditions file created before #1109 will have incorrect values for the baseline conditions over lake columns, and we'll need to overwrite those in initialization. My plan is: If we detect we're working with an old initial conditions file, act as though reset_dynbal_baselines is set, but just for lake columns.

@Ivanderkelen - letting you know about this, but there's nothing you need to do at this point. I'll show you the (possibly rather extensive) changes I'm needing to make for this to work once they're done.

@billsacks billsacks added the enhancement new capability or improved behavior of existing capability label Sep 2, 2020
@billsacks billsacks self-assigned this Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant