You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For the sake of dynamic lakes, we need to add lake water to dynbal baselines. This is done as part of #1109 , but I'm opening a separate issue to track this since it's leading to some subtle issues with respect to old initial conditions files: I think we need to put in place some code for the sake of backwards compatibility with these old initial conditions files: Any initial conditions file created before #1109 will have incorrect values for the baseline conditions over lake columns, and we'll need to overwrite those in initialization. My plan is: If we detect we're working with an old initial conditions file, act as though reset_dynbal_baselines is set, but just for lake columns.
@Ivanderkelen - letting you know about this, but there's nothing you need to do at this point. I'll show you the (possibly rather extensive) changes I'm needing to make for this to work once they're done.
The text was updated successfully, but these errors were encountered:
For the sake of dynamic lakes, we need to add lake water to dynbal baselines. This is done as part of #1109 , but I'm opening a separate issue to track this since it's leading to some subtle issues with respect to old initial conditions files: I think we need to put in place some code for the sake of backwards compatibility with these old initial conditions files: Any initial conditions file created before #1109 will have incorrect values for the baseline conditions over lake columns, and we'll need to overwrite those in initialization. My plan is: If we detect we're working with an old initial conditions file, act as though
reset_dynbal_baselines
is set, but just for lake columns.@Ivanderkelen - letting you know about this, but there's nothing you need to do at this point. I'll show you the (possibly rather extensive) changes I'm needing to make for this to work once they're done.
The text was updated successfully, but these errors were encountered: