Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication between phys versions in CLM_BLDNML_OPTS settings (and fix some others) in config_component.xml #1168

Closed
billsacks opened this issue Sep 30, 2020 · 0 comments · Fixed by #1164
Assignees
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)

Comments

@billsacks
Copy link
Member

When reviewing the changes for ctsm5.1.dev001, I noticed that we have duplication here:

<value compset="_CLM45%[^_]*SP" >-bgc sp</value>
<value compset="_CLM45%[^_]*CN" >-bgc cn</value>
<value compset="_CLM45%[^_]*BGC" >-bgc bgc</value>
<value compset="_CLM45%[^_]*CN-CROP" >-bgc cn -crop</value>
<value compset="_CLM45%[^_]*BGC-CROP" >-bgc bgc -crop</value>
<value compset="_CLM45%[^_]*CNDV" >-bgc cn -dynamic_vegetation</value>
<value compset="_CLM45%[^_]*BGCDV" >-bgc bgc -dynamic_vegetation</value>
<value compset="_CLM45%[^_]*CNDV-CROP" >-bgc cn -dynamic_vegetation -crop</value>
<value compset="_CLM45%[^_]*BGCDV-CROP" >-bgc bgc -dynamic_vegetation -crop</value>
<value compset="_CLM45%[^_]*SP-VIC" >-bgc sp -vichydro </value>
<value compset="_CLM45%[^_]*FATES" >-bgc fates -no-megan</value>
<value compset="_CLM50%[^_]*SP" >-bgc sp</value>
<value compset="_CLM50%[^_]*BGC" >-bgc bgc</value>
<value compset="_CLM50%[^_]*BGCDV" >-bgc bgc -dynamic_vegetation</value>
<value compset="_CLM50%[^_]*BGC-CROP" >-bgc bgc -crop</value>
<value compset="_CLM50%[^_]*CN" >-bgc cn</value>
<value compset="_CLM50%[^_]*CN-CROP" >-bgc cn -crop</value>
<value compset="_CLM50%[^_]*CNDV" >-bgc cn -dynamic_vegetation</value>
<value compset="_CLM50%[^_]*CNDV-CROP" >-bgc cn -dynamic_vegetation -crop</value>
<value compset="_CLM50%[^_]*BGCDV-CROP" >-bgc bgc -dynamic_vegetation -crop</value>
<value compset="_CLM50%[^_]*SP-VIC" >-bgc sp -vichydro </value>
<value compset="_CLM50%[^_]*FATES" >-bgc fates -no-megan</value>
<value compset="_CLM51%[^_]*SP" >-bgc sp</value>
<value compset="_CLM51%[^_]*BGC" >-bgc bgc</value>
<value compset="_CLM51%[^_]*BGC-CROP" >-bgc bgc -crop</value>
<value compset="_CLM51%[^_]*FATES" >-bgc fates -no-megan</value>

Given that this section already has felt error-prone to me, I feel that we shouldn't make it worse by duplicating settings for different physics versions. So, for example, rather than these three lines:

<value compset="_CLM45%[^_]*SP"		 >-bgc sp</value>
<value compset="_CLM50%[^_]*SP"		 >-bgc sp</value>
<value compset="_CLM51%[^_]*SP"		 >-bgc sp</value>

(and we'll need more in the future)

I feel we should have a single line like this:

<value compset="_CLM[^_]*%SP"		 >-bgc sp</value>

I think the same applies to:

  • CLM_NML_USE_CASE: the match for 1850_noanthro_control needs to be changed to work for other phys versions
  • CLM_USER_MODS

@ekluzek it looks like you intentionally removed some options (like CNDV) for CLM51. I think this removal can still be accomplished by leaving these out of the description section, as you have done.

@billsacks billsacks added code health improving internal code structure to make easier to maintain (sustainability) tag: simple bfb labels Sep 30, 2020
@ekluzek ekluzek self-assigned this Sep 30, 2020
ekluzek added a commit to olyson/ctsm that referenced this issue Jun 10, 2021
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants