Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soil tillage for crops #2040

Merged
merged 104 commits into from
Jan 10, 2024

Enable tillage in two aux_clm tests.

142c2c1
Select commit
Loading
Failed to load commit list.
Merged

Add soil tillage for crops #2040

Enable tillage in two aux_clm tests.
142c2c1
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Jan 10, 2024 in 0s

23 / 23 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Resolves #112. Incomplete
Adds parameter tillage_mode with options off (default), low, and high. Incomplete
Adds parameter use_original_tillage_phases (false by default; see "Substantive changes" below). Incomplete
Adds parameter max_tillage_depth. Incomplete
Unit tests pass. Incomplete
aux_clm tests OK (NLFAIL) except for expected failures. Baseline saved as tillage.d43c6178c. Incomplete
I left out the dependence of decomposition multipliers on GDP. Code for distinguishing more- vs. less-developed countries was in the original branch, but the "less developed country" option was hard-coded to always be used. (Note that what I brought in reflects the description in Graham et al. (2021).) Incomplete
The original code calculates but ignores "days past planting" (idpp), using instead a calculation that seems incorrect for growing seasons that cross over into a new calendar year. This version uses idpp instead. However, the old version can be used by setting use_original_tillage_phases to true. Incomplete
Default max_tillage_depth is 26 cm. This was the intention of the original code, but it accidentally used 32 cm. Incomplete
The effects of tillage on soil physical properties and albedo are not considered. Incomplete
Tillage is either enabled or disabled globally for all CFTs. There is no option to limit it to only some CFTs and/or gridcells. Incomplete
@wwieder: Should I extend this to work with MIMICS decomposition? Doing so would require some scientific thinking and probably literature review. Yes; done. Completed
Should I extend this to work with FATES? I think the only reason I disabled that is because I'm unsure how/whether coarse woody debris, which FATES handles, should be affected by tillage. Yes. Completed
Should I bring in (an option to enable) GDP dependence, as was in the original code but unused? Unfortunately the "developed country" version uses hard-coded dates to determine decomposition multiplier; we'd surely want to generalize that but it'd require a discussion. Not doing this for now, as it seems to have only been an initial attempt. Completed
Should I move the 54 decomposition multipliers (currently hard-coded) to the parameters file? Yes; done. Completed
Is there a simpler way than this to get the active patch associated with a given crop column? Seemingly no. Completed
Should I add a test in testlist_clm.xml that uses the till testdef? And/or, should I edit one of the aux_clm tests to use it instead of crop? Completed
aux_clm Completed
Replace paramfile paths Completed
Scientific testing Completed
Add Tech Note documentation in Decomposition (link from Crop/irrigation) Completed
Add User Guide documentation in "Running special cases" Completed
Add till testdef. Completed
i_pas_som → i_phys_som Incomplete
i_slo_som → i_chem_som Incomplete
i_act_som → i_avl_som Incomplete
i_cel_lit + i_lig_lit → i_str_lit Incomplete
Are there bgc_ variables on param file that are intended for CENTURY? If so, prefix till_decompk_multipliers likewise. Done with cb5a889. Completed
In first readParams_netcdf() return check, use integer tillage_intensity instead of string tillage_mode. Done with fe568e1. Completed
Instead of hard-coding tillage to affect just the top 5 soil layers, use a namelist variable to set the max depth of tillage effects. Done by 8e67f28. Completed
In check of sumwt, also check whether it's below 1. Done with 9063873. Completed
Make function to share idpp calculation with CropPhenology(). Done with f01adc6. Completed
Delete "Test identicality when using get_prev_days_per_year()" todo c8d6754 Completed
Correct comment about "uses get_prev_calday() instead of get_curr_calday()". 7510431 Completed
Do not till generic crops. d565176 Completed
Warn instead of error when trying to enable tillage, allowing override. b86402e Completed
Delete add_tillage_to_paramsfile.py. 1a3a8b7 Completed
Use ntill_intensities_max; set to private. ae56384, 693750c Completed
View more details on Task list completed