Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify naming and attributes of time variables on history files to be consistent with other CESM components #22

Closed
phillips-ad opened this issue Apr 1, 2022 · 1 comment
Labels
wontfix This will not be worked on

Comments

@phillips-ad
Copy link

These changes are being requested to improve the ease-of-access of CESM data and to normalize the look of the metadata across CESM components. See ESCOMP/CESM#194 and especially the google doc referenced from ESCOMP/CESM#194 (comment).

Current time array output:

double time(time) ;
	time:units = "seconds since YYYY-MM-DD HH:MM:SS" ;
	time:calendar = "noleap" ;

Proposed time array output:

double time(time) ;
	time:long_name = "time" ;
	time:units = "days since YYYY-MM-DD HH:MM:SS" ;
	time:bounds = "time_bounds" ;
	time:calendar = "noleap" ;
double time_bounds(time, nbnd) ;
	time_bounds:long_name = "time interval endpoints" ;
	time_bounds:units = "days since YYYY-MM-DD HH:MM:SS" ;
	time_bounds:calendar = "noleap" ;

Changes made: change units of time to “days since”, add long_name and bounds attributes, add time_bounds array and long_name, units and calendar attributes

There is a difference in the time@units values between MOM6 (days since 0001-01-01 00:00:00) and WW3 (seconds since the start of the run). I do not know if this is a big deal or not. Regardless, the matching request for MOM6 can be found at ESCOMP/MOM_interface#107.

@billsacks @phillips-ad @strandwg are filing similar issues for each component.

@billsacks
Copy link
Member

Based on discussion with @klindsay28 and @phillips-ad this isn't feasible for CESM3 and isn't critical, so we're closing it as a wontfix.

@billsacks billsacks closed this as not planned Won't fix, can't repro, duplicate, stale Apr 16, 2024
@github-project-automation github-project-automation bot moved this from Needs Prioritization to Done (or no longer holding things up) in CESM: infrastructure / cross-component SE priorities Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
Status: Done (or no longer holding things up)
Development

No branches or pull requests

2 participants