Add default query #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenrdz
force-pushed
the
default-query
branch
from
555f06f to
896891a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module changes
Add
Config.api.default_query_idstring option (default=""). This enables using a pre-existing query as a parent applied to all queries having no require.Add
Esgpull.insert_default_querymethod to insert the default query specified in the config to queries having no require, and update children queriesrequirevalue accordingly.CLI changes
For both
addandsearchcommands, the default query specified in the config is inserted as arequireto any "require-less" query provided from the command's arguments.Add
--no-default-queryoption toaddandsearchcommands, to disable the default query mechanism. This is effectively useless if no default query is specified in the config.