Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_clone cannot be called without case_setup #1304

Closed
jedwards4b opened this issue Apr 5, 2017 · 1 comment
Closed

create_clone cannot be called without case_setup #1304

jedwards4b opened this issue Apr 5, 2017 · 1 comment
Assignees
@gold2718 @jedwards4b @billsacks

Comments

@jedwards4b
Copy link
Contributor

If create_clone is called before case.setup is called on a case bad things can happen.
For example #1272 where the second case does not have the pio_typename set correctly.
I think that the correct action for this is to require case_setup is called on case1 before create_clone can be.

This would require refactoring the system_tests_compare_two script so that case1 setup is done before the case clone.
@jedwards4b jedwards4b mentioned this issue Apr 5, 2017
Closed
@jedwards4b
Copy link
Contributor Author

No this wouldn't solve the problem: The problem is that the PIO_TYPENAME valid_values is set during the build phase depending on what supporting libraries pio found during it's build. If create_clone is run prior to the first case being built AND --keepexe is used then the second case is never required to do a build and so the valid_values list for pio_typename is not updated. When the case1 build is done there is no way to know that more than one case depends on the build and so no way to update clones with the correct valid_values.

@jedwards4b jedwards4b mentioned this issue Apr 5, 2017
Merged
@ghost ghost assigned jedwards4b Apr 5, 2017
@ghost ghost added the in progress label Apr 5, 2017
@ghost ghost removed the in progress label Apr 11, 2017
jedwards4b added a commit that referenced this issue Apr 11, 2017
@jedwards4b
Merge pull request #1305 from jedwards4b/clone_keepexe_and_pio_typename
82b6181 
avoid a problem with pio_typename in clone with keepexe
Print a warning if create_clone is run before case1 is built. Add code to system_tests_compare_two to update pio_typename in case2 after case1 build is complete.

Test suite: scripts_regression_tests
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1304

User interface changes?:

Code review: @gold2718 @billsacks @mvertens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gold2718 gold2718

@jedwards4b jedwards4b

@billsacks billsacks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gold2718 @jedwards4b @billsacks