Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hovmoeller Z vs. time plot to monitoring diagnostic (for Changelog v2.10: authors: @cubeme and @helgehr) #3345

Merged
merged 15 commits into from
Sep 7, 2023

Conversation

cubeme
Copy link
Contributor

@cubeme cubeme commented Sep 6, 2023

Description

This PR adds functionality for plotting Hovmoeller z vs. time plots.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@lukruh lukruh self-requested a review September 6, 2023 14:09
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cubeme and @helgehr, that looks fantastic! I have some very minor comments (if you agree with them, you can just accept the suggestions here on GitHub). Once they are resolved, I will give this a final test and merge 👍

esmvaltool/config-references.yml Show resolved Hide resolved
esmvaltool/diag_scripts/monitor/multi_datasets.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/monitor/multi_datasets.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/monitor/multi_datasets.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/monitor/multi_datasets.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/monitor/multi_datasets.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/monitor/multi_datasets.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/monitor/multi_datasets.py Outdated Show resolved Hide resolved
@schlunma schlunma changed the title Add Hovmoeller z vs time plot Add Hovmoeller Z vs. time plot to monitoring diagnostic (for Changelog v2.10: authors: @cubeme and @helgehr) Sep 7, 2023
@schlunma schlunma added this to the v2.10.0 milestone Sep 7, 2023
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with actual data, everything looks and works as expected. Thanks @cubeme and @helgehr 🚀

@schlunma schlunma merged commit 41acdb3 into main Sep 7, 2023
1 of 2 checks passed
@schlunma schlunma deleted the hovmoeller_z_time branch September 7, 2023 10:22
jvegreg pushed a commit that referenced this pull request Jan 14, 2024
…g v2.10: authors: @cubeme and @helgehr) (#3345)

Co-authored-by: Helge Heuer <helge.heuer@dlr.de>
Co-authored-by: helgehr <38046421+helgehr@users.noreply.github.com>
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Co-authored-by: Manuel Schlund <manuel.schlund@dlr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hovmöller Z vs. time plot to diagnostic monitor/multi_datsets.py
4 participants