From 738c4783ab05190c14de42ff8a9a452ed7059509 Mon Sep 17 00:00:00 2001
From: Patric Stout <github@truebrain.nl>
Date: Fri, 22 Dec 2023 20:32:08 +0100
Subject: [PATCH] chore: refactor FitButtonBar into several smaller components

---
 src/FitButtonBar/ClipboardButton.tsx |  85 ++++++++++++
 src/FitButtonBar/FitButtonBar.tsx    | 198 +--------------------------
 src/FitButtonBar/RenameButton.tsx    |  41 ++++++
 src/FitButtonBar/SaveButton.tsx      |  67 +++++++++
 src/FitButtonBar/ShareButton.tsx     |  24 ++++
 5 files changed, 221 insertions(+), 194 deletions(-)
 create mode 100644 src/FitButtonBar/ClipboardButton.tsx
 create mode 100644 src/FitButtonBar/RenameButton.tsx
 create mode 100644 src/FitButtonBar/SaveButton.tsx
 create mode 100644 src/FitButtonBar/ShareButton.tsx

diff --git a/src/FitButtonBar/ClipboardButton.tsx b/src/FitButtonBar/ClipboardButton.tsx
new file mode 100644
index 0000000..072b7b9
--- /dev/null
+++ b/src/FitButtonBar/ClipboardButton.tsx
@@ -0,0 +1,85 @@
+import clsx from "clsx";
+import React from "react";
+
+import { EsiFit, ShipSnapshotContext } from "../ShipSnapshotProvider";
+import { ModalDialog } from "../ModalDialog";
+import { useClipboard } from "../Helpers/Clipboard";
+import { useFormatAsEft } from "../FormatAsEft";
+import { useFormatEftToEsi } from "../FormatEftToEsi";
+
+import styles from "./FitButtonBar.module.css";
+
+export const ClipboardButton = () => {
+  const shipSnapshot = React.useContext(ShipSnapshotContext);
+  const toEft = useFormatAsEft();
+  const eftToEsiFit = useFormatEftToEsi();
+  const { copy, copied } = useClipboard();
+
+  const [isPopupOpen, setIsPopupOpen] = React.useState(false);
+  const [isPasteOpen, setIsPasteOpen] = React.useState(false);
+  const textAreaRef = React.useRef<HTMLTextAreaElement>(null);
+
+  const copyToClipboard = React.useCallback(() => {
+    const eft = toEft();
+    if (eft === undefined) return;
+
+    copy(eft);
+
+    setIsPopupOpen(false);
+  }, [copy, toEft]);
+
+  const importFromClipboard = React.useCallback(() => {
+    if (!shipSnapshot.loaded) return;
+
+    const textArea = textAreaRef.current;
+    if (textArea === null) return;
+
+    const fitString = textArea.value;
+    if (fitString === "") return;
+
+    let fit: EsiFit | undefined;
+    if (fitString.startsWith("{")) {
+      fit = JSON.parse(fitString);
+    } else {
+      fit = eftToEsiFit(fitString);
+    }
+    if (fit === undefined) return;
+
+    shipSnapshot.changeFit(fit);
+
+    setIsPasteOpen(false);
+    setIsPopupOpen(false);
+  }, [eftToEsiFit, shipSnapshot]);
+
+  return <>
+    <div className={styles.popupButton} onMouseOver={() => setIsPopupOpen(true)} onMouseOut={() => setIsPopupOpen(false)}>
+      <div className={styles.button}>
+        {copied ? "In Clipboard" : "Clipboard"}
+      </div>
+      <div className={clsx(styles.popup, {[styles.collapsed]: !isPopupOpen})}>
+        <div>
+          <div className={styles.button} onClick={() => setIsPasteOpen(true)}>
+            Import from Clipboard
+          </div>
+          <div className={clsx(styles.button, styles.buttonMax)} onClick={() => copyToClipboard()}>
+            Copy to Clipboard
+          </div>
+        </div>
+      </div>
+    </div>
+
+    <ModalDialog visible={isPasteOpen} onClose={() => setIsPasteOpen(false)} className={styles.paste} title="Import from Clipboard">
+      <div>
+        <div>
+          Paste your fit here
+        </div>
+        <div>
+          <textarea autoFocus className={styles.pasteTextarea} ref={textAreaRef} />
+        </div>
+        <span className={clsx(styles.button, styles.buttonSmall)} onClick={() => importFromClipboard()}>
+          Import
+        </span>
+      </div>
+    </ModalDialog>
+  </>
+}
diff --git a/src/FitButtonBar/FitButtonBar.tsx b/src/FitButtonBar/FitButtonBar.tsx
index 80bfb46..00a7e32 100644
--- a/src/FitButtonBar/FitButtonBar.tsx
+++ b/src/FitButtonBar/FitButtonBar.tsx
@@ -1,202 +1,12 @@
-import clsx from "clsx";
 import React from "react";
 
-import { EsiFit, ShipSnapshotContext } from "../ShipSnapshotProvider";
-import { LocalFitContext } from "../LocalFitProvider";
-import { ModalDialog } from "../ModalDialog";
-import { useClipboard } from "../Helpers/Clipboard";
-import { useEveShipFitLink } from "../EveShipFitLink";
-import { useFormatAsEft } from "../FormatAsEft";
-import { useFormatEftToEsi } from "../FormatEftToEsi";
+import { SaveButton } from "./SaveButton";
+import { ClipboardButton } from "./ClipboardButton";
+import { ShareButton } from "./ShareButton";
+import { RenameButton } from "./RenameButton";
 
 import styles from "./FitButtonBar.module.css";
 
-const SaveButton = () => {
-  const shipSnapshot = React.useContext(ShipSnapshotContext);
-  const localFit = React.useContext(LocalFitContext);
-
-  const [isPopupOpen, setIsPopupOpen] = React.useState(false);
-  const [isAlreadyExistsOpen, setIsAlreadyExistsOpen] = React.useState(false);
-
-  const saveBrowser = React.useCallback((force?: boolean) => {
-    if (!localFit.loaded) return;
-    if (!shipSnapshot.loaded || !shipSnapshot?.fit) return;
-
-    setIsPopupOpen(false);
-
-    if (!force) {
-      for (const fit of localFit.fittings) {
-        if (fit.name === shipSnapshot.fit.name) {
-          setIsAlreadyExistsOpen(true);
-          return;
-        }
-      }
-    }
-
-    setIsAlreadyExistsOpen(false);
-
-    localFit.addFit(shipSnapshot.fit);
-  }, [localFit, shipSnapshot]);
-
-  return <>
-    <div className={styles.popupButton} onMouseOver={() => setIsPopupOpen(true)} onMouseOut={() => setIsPopupOpen(false)}>
-      <div className={styles.button}>
-        Save
-      </div>
-      <div className={clsx(styles.popup, {[styles.collapsed]: !isPopupOpen})}>
-        <div>
-          <div className={styles.button} onClick={() => saveBrowser()}>
-            Save in Browser
-          </div>
-        </div>
-      </div>
-    </div>
-
-    <ModalDialog visible={isAlreadyExistsOpen} onClose={() => setIsAlreadyExistsOpen(false)} className={styles.alreadyExists} title="Update Fitting?">
-      <div>
-        <div>
-          You have a fitting with the name {shipSnapshot?.fit?.name}, do you want to update it?
-        </div>
-        <div className={styles.alreadyExistsButtons}>
-          <span className={clsx(styles.button, styles.buttonSmall)} onClick={() => saveBrowser(true)}>
-            Yes
-          </span>
-          <span className={clsx(styles.button, styles.buttonSmall)} onClick={() => setIsAlreadyExistsOpen(false)}>
-            No
-          </span>
-        </div>
-      </div>
-    </ModalDialog>
-  </>
-}
-
-const ClipboardButton = () => {
-  const shipSnapshot = React.useContext(ShipSnapshotContext);
-  const toEft = useFormatAsEft();
-  const eftToEsiFit = useFormatEftToEsi();
-  const { copy, copied } = useClipboard();
-
-  const [isPopupOpen, setIsPopupOpen] = React.useState(false);
-  const [isPasteOpen, setIsPasteOpen] = React.useState(false);
-  const textAreaRef = React.useRef<HTMLTextAreaElement>(null);
-
-  const copyToClipboard = React.useCallback(() => {
-    const eft = toEft();
-    if (eft === undefined) return;
-
-    copy(eft);
-
-    setIsPopupOpen(false);
-  }, [copy, toEft]);
-
-  const importFromClipboard = React.useCallback(() => {
-    if (!shipSnapshot.loaded) return;
-
-    const textArea = textAreaRef.current;
-    if (textArea === null) return;
-
-    const fitString = textArea.value;
-    if (fitString === "") return;
-
-    let fit: EsiFit | undefined;
-    if (fitString.startsWith("{")) {
-      fit = JSON.parse(fitString);
-    } else {
-      fit = eftToEsiFit(fitString);
-    }
-    if (fit === undefined) return;
-
-    shipSnapshot.changeFit(fit);
-
-    setIsPasteOpen(false);
-    setIsPopupOpen(false);
-  }, [eftToEsiFit, shipSnapshot]);
-
-  return <>
-    <div className={styles.popupButton} onMouseOver={() => setIsPopupOpen(true)} onMouseOut={() => setIsPopupOpen(false)}>
-      <div className={styles.button}>
-        {copied ? "In Clipboard" : "Clipboard"}
-      </div>
-      <div className={clsx(styles.popup, {[styles.collapsed]: !isPopupOpen})}>
-        <div>
-          <div className={styles.button} onClick={() => setIsPasteOpen(true)}>
-            Import from Clipboard
-          </div>
-          <div className={clsx(styles.button, styles.buttonMax)} onClick={() => copyToClipboard()}>
-            Copy to Clipboard
-          </div>
-        </div>
-      </div>
-    </div>
-
-    <ModalDialog visible={isPasteOpen} onClose={() => setIsPasteOpen(false)} className={styles.paste} title="Import from Clipboard">
-      <div>
-        <div>
-          Paste your fit here
-        </div>
-        <div>
-          <textarea autoFocus className={styles.pasteTextarea} ref={textAreaRef} />
-        </div>
-        <span className={clsx(styles.button, styles.buttonSmall)} onClick={() => importFromClipboard()}>
-          Import
-        </span>
-      </div>
-    </ModalDialog>
-  </>
-}
-
-const ShareButton = () => {
-  const link = useEveShipFitLink();
-  const { copy, copied } = useClipboard();
-
-  const onClick = React.useCallback((e: React.MouseEvent<HTMLDivElement, MouseEvent>) => {
-    e.preventDefault();
-    copy(link);
-  }, [copy, link]);
-
-  return <>
-    <div className={styles.popupButton}>
-      <div className={styles.button} onClick={onClick}>
-      {copied ? "In Clipboard" : "Share Link"}
-      </div>
-    </div>
-  </>
-}
-
-const RenameButton = () => {
-  const shipSnapshot = React.useContext(ShipSnapshotContext);
-
-  const [isRenameOpen, setIsRenameOpen] = React.useState(false);
-  const [rename, setRename] = React.useState("");
-
-  const saveRename = React.useCallback(() => {
-    shipSnapshot?.setName(rename);
-    setIsRenameOpen(false);
-  }, [rename, shipSnapshot]);
-
-  const openRename = React.useCallback(() => {
-    setRename(shipSnapshot?.fit?.name ?? "");
-    setIsRenameOpen(true);
-  }, [shipSnapshot]);
-
-  return <>
-    <div className={styles.button} onClick={() => openRename()}>
-      Rename
-    </div>
-
-    <ModalDialog visible={isRenameOpen} onClose={() => setIsRenameOpen(false)} title="Fit Name">
-      <div>
-        <span className={styles.renameEdit}>
-          <input type="text" autoFocus value={rename} onChange={(e) => setRename(e.target.value)} />
-        </span>
-        <span className={clsx(styles.button, styles.buttonSmall)} onClick={() => saveRename()}>
-          Save
-        </span>
-      </div>
-    </ModalDialog>
-  </>
-}
-
 /**
  * Bar with buttons to load/save fits.
  */
diff --git a/src/FitButtonBar/RenameButton.tsx b/src/FitButtonBar/RenameButton.tsx
new file mode 100644
index 0000000..094ca7b
--- /dev/null
+++ b/src/FitButtonBar/RenameButton.tsx
@@ -0,0 +1,41 @@
+import clsx from "clsx";
+import React from "react";
+
+import { ShipSnapshotContext } from "../ShipSnapshotProvider";
+import { ModalDialog } from "../ModalDialog";
+
+import styles from "./FitButtonBar.module.css";
+
+export const RenameButton = () => {
+  const shipSnapshot = React.useContext(ShipSnapshotContext);
+
+  const [isRenameOpen, setIsRenameOpen] = React.useState(false);
+  const [rename, setRename] = React.useState("");
+
+  const saveRename = React.useCallback(() => {
+    shipSnapshot?.setName(rename);
+    setIsRenameOpen(false);
+  }, [rename, shipSnapshot]);
+
+  const openRename = React.useCallback(() => {
+    setRename(shipSnapshot?.fit?.name ?? "");
+    setIsRenameOpen(true);
+  }, [shipSnapshot]);
+
+  return <>
+    <div className={styles.button} onClick={() => openRename()}>
+      Rename
+    </div>
+
+    <ModalDialog visible={isRenameOpen} onClose={() => setIsRenameOpen(false)} title="Fit Name">
+      <div>
+        <span className={styles.renameEdit}>
+          <input type="text" autoFocus value={rename} onChange={(e) => setRename(e.target.value)} />
+        </span>
+        <span className={clsx(styles.button, styles.buttonSmall)} onClick={() => saveRename()}>
+          Save
+        </span>
+      </div>
+    </ModalDialog>
+  </>
+}
diff --git a/src/FitButtonBar/SaveButton.tsx b/src/FitButtonBar/SaveButton.tsx
new file mode 100644
index 0000000..8712451
--- /dev/null
+++ b/src/FitButtonBar/SaveButton.tsx
@@ -0,0 +1,67 @@
+import clsx from "clsx";
+import React from "react";
+
+import { ShipSnapshotContext } from "../ShipSnapshotProvider";
+import { LocalFitContext } from "../LocalFitProvider";
+import { ModalDialog } from "../ModalDialog";
+
+import styles from "./FitButtonBar.module.css";
+
+export const SaveButton = () => {
+  const shipSnapshot = React.useContext(ShipSnapshotContext);
+  const localFit = React.useContext(LocalFitContext);
+
+  const [isPopupOpen, setIsPopupOpen] = React.useState(false);
+  const [isAlreadyExistsOpen, setIsAlreadyExistsOpen] = React.useState(false);
+
+  const saveBrowser = React.useCallback((force?: boolean) => {
+    if (!localFit.loaded) return;
+    if (!shipSnapshot.loaded || !shipSnapshot?.fit) return;
+
+    setIsPopupOpen(false);
+
+    if (!force) {
+      for (const fit of localFit.fittings) {
+        if (fit.name === shipSnapshot.fit.name) {
+          setIsAlreadyExistsOpen(true);
+          return;
+        }
+      }
+    }
+
+    setIsAlreadyExistsOpen(false);
+
+    localFit.addFit(shipSnapshot.fit);
+  }, [localFit, shipSnapshot]);
+
+  return <>
+    <div className={styles.popupButton} onMouseOver={() => setIsPopupOpen(true)} onMouseOut={() => setIsPopupOpen(false)}>
+      <div className={styles.button}>
+        Save
+      </div>
+      <div className={clsx(styles.popup, {[styles.collapsed]: !isPopupOpen})}>
+        <div>
+          <div className={styles.button} onClick={() => saveBrowser()}>
+            Save in Browser
+          </div>
+        </div>
+      </div>
+    </div>
+
+    <ModalDialog visible={isAlreadyExistsOpen} onClose={() => setIsAlreadyExistsOpen(false)} className={styles.alreadyExists} title="Update Fitting?">
+      <div>
+        <div>
+          You have a fitting with the name {shipSnapshot?.fit?.name}, do you want to update it?
+        </div>
+        <div className={styles.alreadyExistsButtons}>
+          <span className={clsx(styles.button, styles.buttonSmall)} onClick={() => saveBrowser(true)}>
+            Yes
+          </span>
+          <span className={clsx(styles.button, styles.buttonSmall)} onClick={() => setIsAlreadyExistsOpen(false)}>
+            No
+          </span>
+        </div>
+      </div>
+    </ModalDialog>
+  </>
+}
diff --git a/src/FitButtonBar/ShareButton.tsx b/src/FitButtonBar/ShareButton.tsx
new file mode 100644
index 0000000..8626751
--- /dev/null
+++ b/src/FitButtonBar/ShareButton.tsx
@@ -0,0 +1,24 @@
+import React from "react";
+
+import { useClipboard } from "../Helpers/Clipboard";
+import { useEveShipFitLink } from "../EveShipFitLink";
+
+import styles from "./FitButtonBar.module.css";
+
+export const ShareButton = () => {
+  const link = useEveShipFitLink();
+  const { copy, copied } = useClipboard();
+
+  const onClick = React.useCallback((e: React.MouseEvent<HTMLDivElement, MouseEvent>) => {
+    e.preventDefault();
+    copy(link);
+  }, [copy, link]);
+
+  return <>
+    <div className={styles.popupButton}>
+      <div className={styles.button} onClick={onClick}>
+      {copied ? "In Clipboard" : "Share Link"}
+      </div>
+    </div>
+  </>
+}