feature(OCPP1.6): forward VendorWarning appropriately #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-w50
requested review from
hikinggrass,
Pietfried and
maaikez
as code owners
Pietfried
approved these changes
Nov 8, 2024
- this change will treat the `VendorWarning` the same way as `VendorError`, so that also the `error.message` becomes visible in the OCPP StatusNotification message Signed-off-by: aw <aw@pionix.de>
Pietfried
reviewed
Nov 12, 2024
modules/OCPP/doc.rst
Outdated
Comment on lines
284
to
292
| * status notification charge point ``errorCode`` will always be | ||
| ``OtherError`` | ||
| * status notification ``status`` will reflect the present status of the | ||
| charge point | ||
| * status notification ``info`` -> origin of everest error | ||
| * status notification ``vendorErrorCode`` -> everest error type and | ||
| subtype (the error type is simplified, meaning, that its leading part, | ||
| the interface name, is stripped) | ||
| * status notification ``vendorId`` -> everest error message |
There was a problem hiding this comment.
Suggested change
| * status notification charge point ``errorCode`` will always be | |
| ``OtherError`` | |
| * status notification ``status`` will reflect the present status of the | |
| charge point | |
| * status notification ``info`` -> origin of everest error | |
| * status notification ``vendorErrorCode`` -> everest error type and | |
| subtype (the error type is simplified, meaning, that its leading part, | |
| the interface name, is stripped) | |
| * status notification ``vendorId`` -> everest error message | |
| * **StatusNotification.req** property ``errorCode`` will always be | |
| ``OtherError`` | |
| * **StatusNotification.req** property ``status`` will reflect the present status of the | |
| charge point | |
| * **StatusNotification.req** property ``info`` -> origin of EVerest error | |
| * **StatusNotification.req** property ``vendorErrorCode`` -> EVerest error type and | |
| subtype (the error type is simplified, meaning, that its leading part, | |
| the interface name, is stripped) | |
| * **StatusNotification.req** property ``vendorId`` -> EVerest error message |
Pietfried
reviewed
Nov 12, 2024
modules/OCPP/doc.rst
Outdated
|
|
||
| The fields **info**, **vendorId**, and **vendorErrorCode** are set based on the error type and the provided error properties. Please see the | ||
| definition of `get_error_info` to see how the **StatusNotification.req** is constructed based on the given error. | ||
| For all other errors, raised in everest, the following mapping to an |
There was a problem hiding this comment.
Suggested change
| For all other errors, raised in everest, the following mapping to an | |
| For all other errors, raised in EVerest, the following mapping to an |
- the forwarding of everest errors to ocpp status notifications has been
generalized
- the generic mapping from an everest error to an ocpp status
notification is done now as follows:
- status notification charge point error code will always be `OtherError`
- status notification info -> origin of everest error
- status notification vendor error code -> everest error type and
subtype (the error type is simplified, meaning, that its leading
part, the interface name, is stripped)
- status notification vendor id -> everest error message
- the main choice for using the status notification vendor id for the
error message is that it can carry the largest string (255
characters), whereas the other fields only allow up to 50 characters
Signed-off-by: aw <aw@pionix.de>
Signed-off-by: aw <aw@pionix.de>
Signed-off-by: aw <aw@pionix.de>
Signed-off-by: aw <aw@pionix.de>
Signed-off-by: aw <aw@pionix.de>
Signed-off-by: aw <aw@pionix.de>
a-w50
force-pushed
the
feature/forward_vendor_warning_appropriately
branch
from
30d43f8 to
0212d72
Compare
hikinggrass
pushed a commit
that referenced
this pull request
Nov 21, 2024
* feature(OCPP1.6): forward VendorWarning appropriately
- the forwarding of everest errors to ocpp status notifications has been
generalized
- the generic mapping from an everest error to an ocpp status
notification is done now as follows:
- status notification charge point error code will always be `OtherError`
- status notification info -> origin of everest error
- status notification vendor error code -> everest error type and
subtype (the error type is simplified, meaning, that its leading
part, the interface name, is stripped)
- status notification vendor id -> everest error message
- the main choice for using the status notification vendor id for the
error message is that it can carry the largest string (255
characters), whereas the other fields only allow up to 50 characters
Signed-off-by: aw <aw@pionix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VendorWarningthe same way asVendorError, so that also theerror.messagebecomes visible in the OCPP StatusNotification messageDescribe your changes
Issue ticket number and link
Checklist before requesting a review